Remove several preferences from incognito whitelist (10):

The following preferences are removed from the persistent storage list
for incognito mode:
 - kAppListLocalState
 - kHasSeenGoogleAppsPromoPage
 - kOpenPdfDownloadInSystemReader
 - kWatchdogExtensionActive
 - kWebAppCreateInAppsMenu
 - kWebAppCreateInQuickLaunchBar
 - kWebAppCreateOnDesktop

These preferences are either never changed from incognito mode, or if
changed, they do not need to be written to user profile.

Bug: 861722
Change-Id: Ie42d077effeb90cab6b0062991eaf04613faf619
TBR: khmel@chromium.org
TBR: palmer@chromium.org
TBR: rdevlin.cronin@chromium.org
TBR: tmartino@chromium.org
TBR: xiyuan@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1242456Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593833}

chrome/browser/prefs/pref_service_incognito_whitelist.cc

@@ -211,23 +211,9 @@ const char* const kTemporaryIncognitoWhitelist[] = {
     prefs::kWebRTCNonProxiedUdpEnabled,
     prefs::kWebRTCIPHandlingPolicy,
 
-#if defined(OS_WIN)
-#if defined(GOOGLE_CHROME_BUILD)
-    prefs::kHasSeenGoogleAppsPromoPage,
-#endif  // defined(GOOGLE_CHROME_BUILD)
-#endif  // defined(OS_WIN)
-
-#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_MACOSX)
-    prefs::kOpenPdfDownloadInSystemReader,
-#endif
-
     prefs::kDefaultTasksByMimeType,
     prefs::kDefaultTasksBySuffix,
 
-    prefs::kWebAppCreateOnDesktop,
-    prefs::kWebAppCreateInAppsMenu,
-    prefs::kWebAppCreateInQuickLaunchBar,
-
     prefs::kDefaultAudioCaptureDevice,
     prefs::kDefaultVideoCaptureDevice,
     prefs::kMediaDeviceIdSalt,
@@ -242,12 +228,6 @@ const char* const kTemporaryIncognitoWhitelist[] = {
     prefs::kMediaGalleriesRememberedGalleries,
 #endif  // !defined(OS_ANDROID)
 
-#if BUILDFLAG(ENABLE_APP_LIST)
-    prefs::kAppListLocalState,
-#endif  // BUILDFLAG(ENABLE_APP_LIST)
-
-    prefs::kWatchdogExtensionActive,
-
 #if defined(OS_ANDROID)
     prefs::kPartnerBookmarkMappings,
 #endif  // defined(OS_ANDROID)