Commit 3cb1d73d authored by mmenke's avatar mmenke Committed by Commit bot

Remove LOAD_IS_DOWNLOAD network load flag.

As of https://codereview.chromium.org/1008873006 it no longer does
anything.

BUG=426442,318217

Review URL: https://codereview.chromium.org/1045593002

Cr-Commit-Position: refs/heads/master@{#325533}
parent c7c04dc6
...@@ -28,8 +28,7 @@ SupervisedUserBlacklistDownloader::SupervisedUserBlacklistDownloader( ...@@ -28,8 +28,7 @@ SupervisedUserBlacklistDownloader::SupervisedUserBlacklistDownloader(
weak_ptr_factory_(this) { weak_ptr_factory_(this) {
fetcher_->SetRequestContext(request_context); fetcher_->SetRequestContext(request_context);
fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES | fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES);
net::LOAD_IS_DOWNLOAD);
fetcher_->SetAutomaticallyRetryOnNetworkChanges(kNumRetries); fetcher_->SetAutomaticallyRetryOnNetworkChanges(kNumRetries);
fetcher_->SaveResponseToFileAtPath( fetcher_->SaveResponseToFileAtPath(
path, path,
......
...@@ -174,7 +174,7 @@ void ExternalPolicyDataFetcherBackend::StartJob( ...@@ -174,7 +174,7 @@ void ExternalPolicyDataFetcherBackend::StartJob(
++last_fetch_id_, job->url, net::URLFetcher::GET, this); ++last_fetch_id_, job->url, net::URLFetcher::GET, this);
fetcher->SetRequestContext(request_context_.get()); fetcher->SetRequestContext(request_context_.get());
fetcher->SetLoadFlags(net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE | fetcher->SetLoadFlags(net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE |
net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_IS_DOWNLOAD | net::LOAD_DO_NOT_SAVE_COOKIES |
net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SEND_AUTH_DATA); net::LOAD_DO_NOT_SEND_AUTH_DATA);
fetcher->SetAutomaticallyRetryOnNetworkChanges(3); fetcher->SetAutomaticallyRetryOnNetworkChanges(3);
......
...@@ -613,7 +613,7 @@ DownloadInterruptReason ResourceDispatcherHostImpl::BeginDownload( ...@@ -613,7 +613,7 @@ DownloadInterruptReason ResourceDispatcherHostImpl::BeginDownload(
SetReferrerForRequest(request.get(), referrer); SetReferrerForRequest(request.get(), referrer);
int extra_load_flags = net::LOAD_IS_DOWNLOAD; int extra_load_flags = net::LOAD_NORMAL;
if (prefer_cache) { if (prefer_cache) {
// If there is upload data attached, only retrieve from cache because there // If there is upload data attached, only retrieve from cache because there
// is no current mechanism to prompt the user for their consent for a // is no current mechanism to prompt the user for their consent for a
......
...@@ -46,58 +46,55 @@ LOAD_FLAG(DO_NOT_SAVE_COOKIES, 1 << 7) ...@@ -46,58 +46,55 @@ LOAD_FLAG(DO_NOT_SAVE_COOKIES, 1 << 7)
// to avoid having a circular dependency. // to avoid having a circular dependency.
LOAD_FLAG(BYPASS_PROXY, 1 << 8) LOAD_FLAG(BYPASS_PROXY, 1 << 8)
// Indicate this request is for a download, as opposed to viewing.
LOAD_FLAG(IS_DOWNLOAD, 1 << 9)
// Requires EV certificate verification. // Requires EV certificate verification.
LOAD_FLAG(VERIFY_EV_CERT, 1 << 10) LOAD_FLAG(VERIFY_EV_CERT, 1 << 9)
// This load will not send any cookies. // This load will not send any cookies.
LOAD_FLAG(DO_NOT_SEND_COOKIES, 1 << 11) LOAD_FLAG(DO_NOT_SEND_COOKIES, 1 << 10)
// This load will not send authentication data (user name/password) // This load will not send authentication data (user name/password)
// to the server (as opposed to the proxy). // to the server (as opposed to the proxy).
LOAD_FLAG(DO_NOT_SEND_AUTH_DATA, 1 << 12) LOAD_FLAG(DO_NOT_SEND_AUTH_DATA, 1 << 11)
// This should only be used for testing (set by HttpNetworkTransaction). // This should only be used for testing (set by HttpNetworkTransaction).
LOAD_FLAG(IGNORE_ALL_CERT_ERRORS, 1 << 13) LOAD_FLAG(IGNORE_ALL_CERT_ERRORS, 1 << 12)
// Indicate that this is a top level frame, so that we don't assume it is a // Indicate that this is a top level frame, so that we don't assume it is a
// subresource and speculatively pre-connect or pre-resolve when a referring // subresource and speculatively pre-connect or pre-resolve when a referring
// page is loaded. // page is loaded.
LOAD_FLAG(MAIN_FRAME, 1 << 14) LOAD_FLAG(MAIN_FRAME, 1 << 13)
// Indicate that this is a sub frame, and hence it might have subresources that // Indicate that this is a sub frame, and hence it might have subresources that
// should be speculatively resolved, or even speculatively preconnected. // should be speculatively resolved, or even speculatively preconnected.
LOAD_FLAG(SUB_FRAME, 1 << 15) LOAD_FLAG(SUB_FRAME, 1 << 14)
// If present, intercept actual request/response headers from network stack // If present, intercept actual request/response headers from network stack
// and report them to renderer. This includes cookies, so the flag is only // and report them to renderer. This includes cookies, so the flag is only
// respected if renderer has CanReadRawCookies capability in the security // respected if renderer has CanReadRawCookies capability in the security
// policy. // policy.
LOAD_FLAG(REPORT_RAW_HEADERS, 1 << 16) LOAD_FLAG(REPORT_RAW_HEADERS, 1 << 15)
// Indicates that this load was motivated by the rel=prefetch feature, // Indicates that this load was motivated by the rel=prefetch feature,
// and is (in theory) not intended for the current frame. // and is (in theory) not intended for the current frame.
LOAD_FLAG(PREFETCH, 1 << 17) LOAD_FLAG(PREFETCH, 1 << 16)
// Indicates that this is a load that ignores limits and should complete // Indicates that this is a load that ignores limits and should complete
// immediately. // immediately.
LOAD_FLAG(IGNORE_LIMITS, 1 << 18) LOAD_FLAG(IGNORE_LIMITS, 1 << 17)
// Indicates that the operation is somewhat likely to be due to an // Indicates that the operation is somewhat likely to be due to an
// explicit user action. This can be used as a hint to treat the // explicit user action. This can be used as a hint to treat the
// request with higher priority. // request with higher priority.
LOAD_FLAG(MAYBE_USER_GESTURE, 1 << 19) LOAD_FLAG(MAYBE_USER_GESTURE, 1 << 18)
// Indicates that the username:password portion of the URL should not // Indicates that the username:password portion of the URL should not
// be honored, but that other forms of authority may be used. // be honored, but that other forms of authority may be used.
LOAD_FLAG(DO_NOT_USE_EMBEDDED_IDENTITY, 1 << 20) LOAD_FLAG(DO_NOT_USE_EMBEDDED_IDENTITY, 1 << 19)
// Send request directly to the origin if the effective proxy is the data // Send request directly to the origin if the effective proxy is the data
// reduction proxy. // reduction proxy.
// TODO(rcs): Remove this flag as soon as http://crbug.com/339237 is resolved. // TODO(rcs): Remove this flag as soon as http://crbug.com/339237 is resolved.
LOAD_FLAG(BYPASS_DATA_REDUCTION_PROXY, 1 << 21) LOAD_FLAG(BYPASS_DATA_REDUCTION_PROXY, 1 << 20)
// Indicates the the request is an asynchronous revalidation. // Indicates the the request is an asynchronous revalidation.
LOAD_FLAG(ASYNC_REVALIDATION, 1 << 22) LOAD_FLAG(ASYNC_REVALIDATION, 1 << 21)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment