Commit 3cc57c42 authored by Daniel Cheng's avatar Daniel Cheng Committed by Commit Bot

SequenceBound: migrate from Post() to AsyncCall() in performance manager classes.

Bug: 1140588
Change-Id: I0644c5b7dc043f7d6f04450c580d7116b9eccbab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487687
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: default avatarChris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819107}
parent 9383fe14
...@@ -40,10 +40,11 @@ SiteDataCacheFacade::SiteDataCacheFacade( ...@@ -40,10 +40,11 @@ SiteDataCacheFacade::SiteDataCacheFacade(
} }
// Creates the real cache on the SiteDataCache's sequence. // Creates the real cache on the SiteDataCache's sequence.
SiteDataCacheFacadeFactory::GetInstance()->cache_factory()->Post( SiteDataCacheFacadeFactory::GetInstance()
FROM_HERE, &SiteDataCacheFactory::OnBrowserContextCreated, ->cache_factory()
browser_context->UniqueId(), browser_context->GetPath(), ->AsyncCall(&SiteDataCacheFactory::OnBrowserContextCreated)
parent_context_id); .WithArgs(browser_context->UniqueId(), browser_context->GetPath(),
parent_context_id);
history::HistoryService* history = history::HistoryService* history =
HistoryServiceFactory::GetForProfileWithoutCreating( HistoryServiceFactory::GetForProfileWithoutCreating(
...@@ -54,9 +55,10 @@ SiteDataCacheFacade::SiteDataCacheFacade( ...@@ -54,9 +55,10 @@ SiteDataCacheFacade::SiteDataCacheFacade(
SiteDataCacheFacade::~SiteDataCacheFacade() { SiteDataCacheFacade::~SiteDataCacheFacade() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI); DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
SiteDataCacheFacadeFactory::GetInstance()->cache_factory()->Post( SiteDataCacheFacadeFactory::GetInstance()
FROM_HERE, &SiteDataCacheFactory::OnBrowserContextDestroyed, ->cache_factory()
browser_context_->UniqueId()); ->AsyncCall(&SiteDataCacheFactory::OnBrowserContextDestroyed)
.WithArgs(browser_context_->UniqueId());
SiteDataCacheFacadeFactory::GetInstance()->OnFacadeDestroyed(PassKey()); SiteDataCacheFacadeFactory::GetInstance()->OnFacadeDestroyed(PassKey());
} }
......
...@@ -29,9 +29,9 @@ TEST(SiteDataCacheFactoryTest, EndToEnd) { ...@@ -29,9 +29,9 @@ TEST(SiteDataCacheFactoryTest, EndToEnd) {
PerformanceManager::GetTaskRunner()); PerformanceManager::GetTaskRunner());
content::TestBrowserContext browser_context; content::TestBrowserContext browser_context;
cache_factory.Post(FROM_HERE, &SiteDataCacheFactory::OnBrowserContextCreated, cache_factory.AsyncCall(&SiteDataCacheFactory::OnBrowserContextCreated)
browser_context.UniqueId(), browser_context.GetPath(), .WithArgs(browser_context.UniqueId(), browser_context.GetPath(),
base::nullopt); base::nullopt);
{ {
base::RunLoop run_loop; base::RunLoop run_loop;
...@@ -51,9 +51,8 @@ TEST(SiteDataCacheFactoryTest, EndToEnd) { ...@@ -51,9 +51,8 @@ TEST(SiteDataCacheFactoryTest, EndToEnd) {
run_loop.Run(); run_loop.Run();
} }
cache_factory.Post(FROM_HERE, cache_factory.AsyncCall(&SiteDataCacheFactory::OnBrowserContextDestroyed)
&SiteDataCacheFactory::OnBrowserContextDestroyed, .WithArgs(browser_context.UniqueId());
browser_context.UniqueId());
{ {
base::RunLoop run_loop; base::RunLoop run_loop;
cache_factory.PostTaskWithThisObject( cache_factory.PostTaskWithThisObject(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment