Add missing dependencies
In https://ci.chromium.org/p/chrome/builders/official/mac64/1623: chrome/browser/extensions/api/omnibox/omnibox_api.h includes components/omnibox/browser/autocomplete_match.h includes components/omnibox/browser/buildflags.h This fails due to three bad dependencies. 1. autocomplete_match.h includes buildflags.h, and is included from code outside of components/omnibox/browser so buildflags.h must be a public_deps 2. omnibox_api.h includes autocomplete_match.h so it must declare it in deps 3. because omnibox_api.h is further included outside of chrome/browser/extensions/api/omnibox, its inclusion of autocomplete_match.h means that autocomplete_match.h must be a public_deps (Thanks to rockot@ for the help.) Bug: 1130293 Change-Id: Ic08fbc648c9fed70e853b4c8ab1478fe4626a933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436575Reviewed-by:Tommy Li <tommycli@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811798}
Showing
Please register or sign in to comment