Commit 3cce8de6 authored by Avi Drissman's avatar Avi Drissman Committed by Commit Bot

Add missing dependencies

In https://ci.chromium.org/p/chrome/builders/official/mac64/1623:

chrome/browser/extensions/api/omnibox/omnibox_api.h includes
components/omnibox/browser/autocomplete_match.h includes
components/omnibox/browser/buildflags.h

This fails due to three bad dependencies.

1. autocomplete_match.h includes buildflags.h, and is included
   from code outside of components/omnibox/browser so buildflags.h
   must be a public_deps
2. omnibox_api.h includes autocomplete_match.h so it must
   declare it in deps
3. because omnibox_api.h is further included outside of
   chrome/browser/extensions/api/omnibox, its inclusion of
   autocomplete_match.h means that autocomplete_match.h
   must be a public_deps

(Thanks to rockot@ for the help.)

Bug: 1130293
Change-Id: Ic08fbc648c9fed70e853b4c8ab1478fe4626a933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436575Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811798}
parent 5098bd4a
......@@ -740,6 +740,7 @@ static_library("extensions") {
"//chrome/browser/extensions/api:api_registration",
"//chrome/common",
"//chrome/common/extensions/api",
"//components/omnibox/browser",
"//components/safe_browsing/core:csd_proto",
"//components/safe_browsing/core:webprotect_proto",
"//components/safe_browsing/core/db:util",
......@@ -807,7 +808,6 @@ static_library("extensions") {
"//components/nacl/common:buildflags",
"//components/navigation_interception",
"//components/net_log",
"//components/omnibox/browser",
"//components/onc",
"//components/page_load_metrics/browser:browser",
"//components/password_manager/core/browser",
......
......@@ -27,6 +27,7 @@ function_registration("api_registration") {
# Different APIs include headers from these targets.
"//chrome/common:mojo_bindings",
"//components/omnibox/browser",
"//components/zoom",
"//content/public/browser",
"//extensions/browser",
......
......@@ -208,6 +208,7 @@ static_library("browser") {
]
public_deps = [
":buildflags",
":location_bar",
"//base",
"//base:i18n",
......@@ -219,7 +220,6 @@ static_library("browser") {
"//url",
]
deps = [
":buildflags",
":in_memory_url_index_cache_proto",
"//components/bookmarks/browser",
"//components/component_updater",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment