assistant: only refresh token when running

Before we may set auth token while assistant manager is creating, now
we wait for it to reach running state to refresh token.  This may happen
during start and settings toggles.

Bug: b:113591813
Test: locally compile
Change-Id: Iccc672844734be3a25d4b6cc761cc16cbe8e0d34
Reviewed-on: https://chromium-review.googlesource.com/1197844Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587818}

chromeos/services/assistant/service.cc

@@ -25,7 +25,6 @@
 #include "services/service_manager/public/cpp/service_context.h"
 
 #if BUILDFLAG(ENABLE_CROS_LIBASSISTANT)
-#include "ash/public/interfaces/constants.mojom.h"
 #include "chromeos/assistant/internal/internal_constants.h"
 #include "chromeos/services/assistant/assistant_manager_service_impl.h"
 #include "chromeos/services/assistant/assistant_settings_manager_impl.h"
@@ -261,21 +260,26 @@ void Service::GetAccessTokenCallback(const base::Optional<std::string>& token,
   }
 
   DCHECK(assistant_manager_service_);
-  if (assistant_manager_service_->GetState() ==
-      AssistantManagerService::State::STOPPED) {
-    assistant_manager_service_->Start(
-        token.value(),
-        base::BindOnce(
-            [](scoped_refptr<base::SingleThreadTaskRunner> task_runner,
-               base::OnceCallback<void()> callback) {
-              task_runner->PostTask(FROM_HERE, std::move(callback));
-            },
-            main_thread_task_runner_,
-            base::BindOnce(&Service::FinalizeAssistantManagerService,
-                           weak_ptr_factory_.GetWeakPtr())));
-    DVLOG(1) << "Request Assistant start";
-  } else {
-    assistant_manager_service_->SetAccessToken(token.value());
+  switch (assistant_manager_service_->GetState()) {
+    case AssistantManagerService::State::STOPPED:
+      assistant_manager_service_->Start(
+          token.value(),
+          base::BindOnce(
+              [](scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+                 base::OnceCallback<void()> callback) {
+                task_runner->PostTask(FROM_HERE, std::move(callback));
+              },
+              main_thread_task_runner_,
+              base::BindOnce(&Service::FinalizeAssistantManagerService,
+                             weak_ptr_factory_.GetWeakPtr())));
+      DVLOG(1) << "Request Assistant start";
+      break;
+    case AssistantManagerService::State::RUNNING:
+      assistant_manager_service_->SetAccessToken(token.value());
+      break;
+    case AssistantManagerService::State::STARTED:
+      // in the process of starting, no need to do anything.
+      break;
   }
 
   token_refresh_timer_->Start(FROM_HERE, expiration_time - base::Time::Now(),