Commit 3cd8a7b8 authored by Christian Dullweber's avatar Christian Dullweber Committed by Commit Bot

Don't translate '[*.]example.com' pattern

This string is an example for a valid content settings pattern.
Most translations leave it untouched but some change the url to
something that is not a valid example domain or breaks the syntax.

Bug: 1095878
Change-Id: I95fa441d9c356fe55e893b6a3ea4f191e03fd9de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249762
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780237}
parent b1a79aa3
......@@ -2269,9 +2269,6 @@
<message name="IDS_SETTINGS_NO_HID_DEVICES_FOUND" desc="Explanation for not showing HID devices in site settings.">
No HID devices found
</message>
<message name="IDS_SETTINGS_ADD_SITE_EXCEPTION_PLACEHOLDER" desc="Placeholder text shown before the user starts typing a new content settings exception for a site." >
[*.]example.com
</message>
<message name="IDS_SETTINGS_ADD_SITE_TITLE" desc="Title for the Add Site dialog">
Add a site
</message>
......
......@@ -1449,8 +1449,6 @@ void AddSiteSettingsStrings(content::WebUIDataSource* html_source,
Profile* profile) {
static constexpr webui::LocalizedString kLocalizedStrings[] = {
{"addSite", IDS_SETTINGS_ADD_SITE},
{"addSiteExceptionPlaceholder",
IDS_SETTINGS_ADD_SITE_EXCEPTION_PLACEHOLDER},
{"addSiteTitle", IDS_SETTINGS_ADD_SITE_TITLE},
#if defined(OS_CHROMEOS)
{"androidSmsNote", IDS_SETTINGS_ANDROID_SMS_NOTE},
......@@ -1975,6 +1973,9 @@ void AddSiteSettingsStrings(content::WebUIDataSource* html_source,
html_source->AddBoolean("enableWebBluetoothNewPermissionsBackend",
base::FeatureList::IsEnabled(
features::kWebBluetoothNewPermissionsBackend));
// The exception placeholder should not be translated. See crbug.com/1095878.
html_source->AddString("addSiteExceptionPlaceholder", "[*.]example.com");
}
#if !defined(OS_CHROMEOS)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment