Skip to content

GitLab

T
tangled
Commit 3cfda456 authored by Yoshifumi Inoue's avatar Yoshifumi Inoue Committed by Commit Bot
Browse files
Options

Rewrite editing/selection/skip-over-uneditable-in-contenteditable.html to use selection_test() 

This patch changes "skip-over-uneditable-in-contenteditable.html" to utilize
|selection_test()| for ease of maintenance.

This patch is a preparation for the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Change-Id: I9aa13fdf989bddbe578676815072ce3b3207bc7d
Reviewed-on: https://chromium-review.googlesource.com/895128Reviewed-by: default avatarYoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533525}
parent 0bd2b06c
Hide whitespace changes
Inline Side-by-side
Showing with 109 additions and 58 deletions
third_party/WebKit/LayoutTests/editing/selection/skip-over-uneditable-in-contenteditable-expected.txt deleted 100644 → 0
View file @ 0bd2b06c
Before
Middle
After
Ensure that extending a selection inside a contentEditable skips past an uneditable region.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS sel.focusNode is after
PASS sel.focusNode.parentElement is before
PASS sel.focusNode is after
PASS sel.focusNode.parentElement is before
PASS sel.focusNode.parentElement is after
PASS sel.focusNode.parentElement is before
PASS successfullyParsed is true
TEST COMPLETE
third_party/WebKit/LayoutTests/editing/selection/skip-over-uneditable-in-contenteditable.html
View file @ 3cfda456
<!DOCTYPE HTML> <!DOCTYPE HTML>
<html> <script src="../../resources/testharness.js"></script>
<body> <script src="../../resources/testharnessreport.js"></script>
<script src="../../resources/js-test.js"></script> <script src="../assert_selection.js"></script>
<div contentEditable>
<p id="before">Before</p>
<p id="middle" contentEditable="false">Middle</p>
<p id="after">After</p>
</div>
<div id="console"></div>
<script> <script>
description("Ensure that extending a selection inside a contentEditable skips past an uneditable region."); // Ensure that extending a selection inside a contenteditable skips past an
// uneditable region.
var before = document.getElementById("before"); // Extend before uneditable
var after = document.getElementById("after"); selection_test(
[
'<div contenteditable>',
'<p>^Before|</p>',
'<p contenteditable="false">Middle</p>',
'<p>After</p>',
'</div>'
],
selection => selection.modify('extend', 'forward', 'character'),
[
'<div contenteditable>',
'<p>^Before</p>',
'<p contenteditable="false">Middle</p>',
'<p>|After</p>',
'</div>'
],
'Extend by character before uneditable');
var sel = window.getSelection(); selection_test(
sel.setBaseAndExtent(before, 0, before, 1); [
sel.modify("extend", "forward", "character"); '<div contenteditable>',
shouldBe("sel.focusNode", "after"); '<p>^Before|</p>',
'<p contenteditable="false">Middle</p>',
'<p>After</p>',
'</div>'
],
selection => selection.modify('extend', 'forward', 'word'),
[
'<div contenteditable>',
'<p>^Before</p>',
'<p contenteditable="false">Middle</p>',
'<p>|After</p>',
'</div>'
],
'Extend by word before uneditable');
sel.setBaseAndExtent(after, 1, after, 0); selection_test(
sel.modify("extend", "backward", "character"); [
shouldBe("sel.focusNode.parentElement", "before"); '<div contenteditable>',
'<p>^Before|</p>',
'<p contenteditable="false">Middle</p>',
'<p>After</p>',
'</div>'
],
selection => selection.modify('extend', 'forward', 'line'),
[
'<div contenteditable>',
'<p>^Before</p>',
'<p contenteditable="false">Middle</p>',
'<p>After|</p>',
'</div>'
],
'Extend by line before uneditable');
sel.setBaseAndExtent(before, 0, before, 1); // Extend after uneditable
sel.modify("extend", "forward", "word"); selection_test(
shouldBe("sel.focusNode", "after"); [
'<div contenteditable>',
'<p>Before</p>',
'<p contenteditable="false">Middle</p>',
'<p>|After^</p>',
'</div>'
],
selection => selection.modify('extend', 'backward', 'character'),
[
'<div contenteditable>',
'<p>Before|</p>',
'<p contenteditable="false">Middle</p>',
'<p>After^</p>',
'</div>'
],
'Extend by character after uneditable');
sel.setBaseAndExtent(after, 1, after, 0); selection_test(
sel.modify("extend", "backward", "word"); [
shouldBe("sel.focusNode.parentElement", "before"); '<div contenteditable>',
'<p>Before</p>',
'<p contenteditable="false">Middle</p>',
'<p>|After^</p>',
'</div>'
],
selection => selection.modify('extend', 'backward', 'word'),
[
'<div contenteditable>',
'<p>Before|</p>',
'<p contenteditable="false">Middle</p>',
'<p>After^</p>',
'</div>'
],
'Extend by word after uneditable');
sel.setBaseAndExtent(before, 0, before, 1); selection_test(
sel.modify("extend", "forward", "line"); [
shouldBe("sel.focusNode.parentElement", "after"); '<div contenteditable>',
'<p>Before</p>',
sel.setBaseAndExtent(after, 1, after, 0); '<p contenteditable="false">Middle</p>',
sel.modify("extend", "backward", "line"); '<p>|After^</p>',
shouldBe("sel.focusNode.parentElement", "before"); '</div>'
],
selection => selection.modify('extend', 'backward', 'line'),
[
'<div contenteditable>',
'<p>|Before</p>',
'<p contenteditable="false">Middle</p>',
'<p>After^</p>',
'</div>'
],
'Extend by line after uneditable');
</script> </script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment