[CodeHealth] Convert c/b/e/api/passwords_private to use modern callback

Bug: 1152279
Change-Id: I82e09683a3af5ed10e1653cc2f743c1a5c639346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643278
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846037}

chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

@@ -241,9 +241,9 @@ bool PasswordsPrivateDelegateImpl::ChangeSavedPassword(
 
 void PasswordsPrivateDelegateImpl::RemoveSavedPasswords(
     const std::vector<int>& ids) {
-  ExecuteFunction(
-      base::Bind(&PasswordsPrivateDelegateImpl::RemoveSavedPasswordsInternal,
-                 base::Unretained(this), ids));
+  ExecuteFunction(base::BindOnce(
+      &PasswordsPrivateDelegateImpl::RemoveSavedPasswordsInternal,
+      base::Unretained(this), ids));
 }
 
 void PasswordsPrivateDelegateImpl::RemoveSavedPasswordsInternal(
@@ -254,7 +254,7 @@ void PasswordsPrivateDelegateImpl::RemoveSavedPasswordsInternal(
 
 void PasswordsPrivateDelegateImpl::RemovePasswordExceptions(
     const std::vector<int>& ids) {
-  ExecuteFunction(base::Bind(
+  ExecuteFunction(base::BindOnce(
       &PasswordsPrivateDelegateImpl::RemovePasswordExceptionsInternal,
       base::Unretained(this), ids));
 }
@@ -266,7 +266,7 @@ void PasswordsPrivateDelegateImpl::RemovePasswordExceptionsInternal(
 }
 
 void PasswordsPrivateDelegateImpl::UndoRemoveSavedPasswordOrException() {
-  ExecuteFunction(base::Bind(
+  ExecuteFunction(base::BindOnce(
       &PasswordsPrivateDelegateImpl::UndoRemoveSavedPasswordOrExceptionInternal,
       base::Unretained(this)));
 }
@@ -592,14 +592,13 @@ PasswordsPrivateDelegateImpl::GetPasswordIdGeneratorForTesting() {
   return password_id_generator_;
 }
 
-void PasswordsPrivateDelegateImpl::ExecuteFunction(
-    const base::Closure& callback) {
+void PasswordsPrivateDelegateImpl::ExecuteFunction(base::OnceClosure callback) {
   if (is_initialized_) {
-    callback.Run();
+    std::move(callback).Run();
     return;
   }
 
-  pre_initialization_callbacks_.push_back(callback);
+  pre_initialization_callbacks_.emplace_back(std::move(callback));
 }
 
 void PasswordsPrivateDelegateImpl::InitializeIfNecessary() {
@@ -609,8 +608,8 @@ void PasswordsPrivateDelegateImpl::InitializeIfNecessary() {
 
   is_initialized_ = true;
 
-  for (const base::Closure& callback : pre_initialization_callbacks_)
-    callback.Run();
+  for (base::OnceClosure& callback : pre_initialization_callbacks_)
+    std::move(callback).Run();
   pre_initialization_callbacks_.clear();
 }
 

chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

@@ -124,7 +124,7 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,
 
   // Executes a given callback by either invoking it immediately if the class
   // has been initialized or by deferring it until initialization has completed.
-  void ExecuteFunction(const base::Closure& callback);
+  void ExecuteFunction(base::OnceClosure callback);
 
   void SendSavedPasswordsList();
   void SendPasswordExceptionsList();
@@ -185,7 +185,7 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,
   // initialized. Once both SetPasswordList() and SetPasswordExceptionList()
   // have been called, this class is considered initialized and can these
   // callbacks are invoked.
-  std::vector<base::Closure> pre_initialization_callbacks_;
+  std::vector<base::OnceClosure> pre_initialization_callbacks_;
   std::vector<UiEntriesCallback> get_saved_passwords_list_callbacks_;
   std::vector<ExceptionEntriesCallback> get_password_exception_list_callbacks_;