Revert "[LanguageDetection] SimpleKeyedService and optimization guide."
This reverts commit ffac4483. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 836656 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmZhYzQ0ODNlNTQ4Y2RmODk3NzJlYmM5ODk5MTM3MDU4OTczOGZjNww Sample Failed Build: https://ci.chromium.org/b/8860905823939722448 Sample Failed Step: browser_tests Sample Flaky Test: TranslateModelServiceWithoutOptimizationGuideBrowserTest.TranslateModelServiceEnabled Original change's description: > [LanguageDetection] SimpleKeyedService and optimization guide. > > > This change converts the translate model service to a > SimpleKeyedService and moves it to components which will enable > easier support beyond just browser use cases. > > This change also registers the translate model service to > the optimization guide for provided necessary model files. > > A future change will add loading and service the model files > to consumers of the translate model service. > > Bug: 1151407 > Change-Id: I4e903115c82a30757d46d75ed8d733874726d830 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580339 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Trevor Perrier <perrier@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836656} Change-Id: I9f63ed714aafbe14ce8c48c23474becadd752186 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591947 Cr-Commit-Position: refs/heads/master@{#836880}
Showing
Please register or sign in to comment