Migrate ExtensionMsg_SetWebViewPartitionID IPC to mojo

This CL migrates the legacy IPC message out of extension_messages.h to
Renderer mojo interface from extensions.mojom.

Bug: 1165814
Change-Id: I338e9e1e59321d143053ec4c47bed7234c04ae5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627270
Commit-Queue: Antia Puentes <apuentes@igalia.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844009}

chrome/browser/extensions/activity_log/activity_log_unittest.cc

@@ -85,6 +85,8 @@ class InterceptingRendererStartupHelper : public RendererStartupHelper,
                       bool is_lock_screen_context) override {}
   void SetSystemFont(const std::string& font_family,
                      const std::string& font_size) override {}
+  void SetWebViewPartitionID(const std::string& partition_id) override {}
+
   mojo::AssociatedReceiverSet<mojom::Renderer> receivers_;
 };
 

extensions/browser/renderer_startup_helper.cc

@@ -138,8 +138,7 @@ void RendererStartupHelper::InitializeProcess(
   // partition ID to it.
   std::string webview_partition_id = WebViewGuest::GetPartitionID(process);
   if (!webview_partition_id.empty()) {
-    process->Send(new ExtensionMsg_SetWebViewPartitionID(
-        WebViewGuest::GetPartitionID(process)));
+    renderer->SetWebViewPartitionID(webview_partition_id);
   }
 
   BrowserContext* renderer_context = process->GetBrowserContext();

extensions/browser/renderer_startup_helper_unittest.cc

@@ -57,6 +57,8 @@ class InterceptingRendererStartupHelper : public RendererStartupHelper,
   void SetSystemFont(const std::string& font_family,
                      const std::string& font_size) override {}
 
+  void SetWebViewPartitionID(const std::string& partition_id) override {}
+
   std::vector<std::string> activated_extensions_;
   std::vector<std::string> unloaded_extensions_;
   mojo::AssociatedReceiverSet<mojom::Renderer> receivers_;

extensions/common/extension_messages.h

@@ -720,10 +720,6 @@ IPC_MESSAGE_CONTROL1(ExtensionMsg_WatchPages,
 IPC_MESSAGE_CONTROL1(ExtensionMsg_TransferBlobs,
                      std::vector<std::string> /* blob_uuids */)
 
-// Report the WebView partition ID to the WebView guest renderer process.
-IPC_MESSAGE_CONTROL1(ExtensionMsg_SetWebViewPartitionID,
-                     std::string /* webview_partition_id */)
-
 // Enable or disable spatial navigation.
 IPC_MESSAGE_ROUTED1(ExtensionMsg_SetSpatialNavigationEnabled,
                     bool /* spatial_nav_enabled */)

extensions/common/mojom/renderer.mojom

@@ -33,4 +33,7 @@ interface Renderer {
 
   // Tells the renderer process the platform's system font.
   SetSystemFont(string font_family, string font_size);
+
+  // Reports the WebView partition ID to the WebView guest renderer process.
+  SetWebViewPartitionID(string partition_id);
 };

extensions/renderer/dispatcher.cc

@@ -876,8 +876,6 @@ bool Dispatcher::OnControlMessageReceived(const IPC::Message& message) {
   IPC_MESSAGE_HANDLER(ExtensionMsg_DispatchEvent, OnDispatchEvent)
   IPC_MESSAGE_HANDLER(ExtensionMsg_SetScriptingAllowlist,
                       OnSetScriptingAllowlist)
-  IPC_MESSAGE_HANDLER(ExtensionMsg_SetWebViewPartitionID,
-                      OnSetWebViewPartitionID)
   IPC_MESSAGE_HANDLER(ExtensionMsg_ShouldSuspend, OnShouldSuspend)
   IPC_MESSAGE_HANDLER(ExtensionMsg_Suspend, OnSuspend)
   IPC_MESSAGE_HANDLER(ExtensionMsg_TransferBlobs, OnTransferBlobs)
@@ -1014,6 +1012,12 @@ void Dispatcher::SetSystemFont(const std::string& font_family,
   system_font_size_ = font_size;
 }
 
+void Dispatcher::SetWebViewPartitionID(const std::string& partition_id) {
+  // |webview_partition_id_| cannot be changed once set.
+  CHECK(webview_partition_id_.empty() || webview_partition_id_ == partition_id);
+  webview_partition_id_ = partition_id;
+}
+
 void Dispatcher::OnCancelSuspend(const std::string& extension_id) {
   DispatchEvent(extension_id, kOnSuspendCanceledEvent, base::ListValue(),
                 nullptr);
@@ -1185,12 +1189,6 @@ void Dispatcher::OnSetScriptingAllowlist(
   ExtensionsClient::Get()->SetScriptingAllowlist(extension_ids);
 }
 
-void Dispatcher::OnSetWebViewPartitionID(const std::string& partition_id) {
-  // |webview_partition_id_| cannot be changed once set.
-  CHECK(webview_partition_id_.empty() || webview_partition_id_ == partition_id);
-  webview_partition_id_ = partition_id;
-}
-
 void Dispatcher::OnShouldSuspend(const std::string& extension_id,
                                  uint64_t sequence_id) {
   RenderThread::Get()->Send(

extensions/renderer/dispatcher.h

@@ -222,6 +222,7 @@ class Dispatcher : public content::RenderThreadObserver,
                       bool lock_screen_context) override;
   void SetSystemFont(const std::string& font_family,
                      const std::string& font_size) override;
+  void SetWebViewPartitionID(const std::string& partition_id) override;
   void OnRendererAssociatedRequest(
       mojo::PendingAssociatedReceiver<mojom::Renderer> receiver);
   void OnCancelSuspend(const std::string& extension_id);
@@ -246,7 +247,6 @@ class Dispatcher : public content::RenderThreadObserver,
                        const base::ListValue& event_args);
   void OnSetScriptingAllowlist(
       const ExtensionsClient::ScriptingAllowlist& extension_ids);
-  void OnSetWebViewPartitionID(const std::string& partition_id);
   void OnShouldSuspend(const std::string& extension_id, uint64_t sequence_id);
   void OnSuspend(const std::string& extension_id);
   void OnTransferBlobs(const std::vector<std::string>& blob_uuids);