[Autofill Assistant] Implement the navigate action.

This change introduces support for the action navigate, which tells the
browser to go to a specific URL. The action finishes without waiting for
the new page to load.

Bug: 806868
Change-Id: Ibe354eb627b836e6e1d5ad5ff461a8b392102faa
Reviewed-on: https://chromium-review.googlesource.com/1248783
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595061}

components/autofill_assistant/browser/BUILD.gn

@@ -22,6 +22,8 @@ jumbo_static_library("browser") {
     "actions/click_action.h",
     "actions/focus_element_action.cc",
     "actions/focus_element_action.h",
+    "actions/navigate_action.cc",
+    "actions/navigate_action.h",
     "actions/reset_action.cc",
     "actions/reset_action.h",
     "actions/select_option_action.cc",

components/autofill_assistant/browser/actions/action_delegate.h

@@ -10,6 +10,8 @@
 
 #include "base/callback_forward.h"
 
+class GURL;
+
 namespace autofill {
 class AutofillProfile;
 }
@@ -90,6 +92,10 @@ class ActionDelegate {
                              NodeProto* node_tree_out,
                              base::OnceCallback<void(bool)> callback) = 0;
 
+  // Load |url| in the current tab. Returns immediately, before the new page has
+  // been loaded.
+  virtual void LoadURL(const GURL& url) = 0;
+
   // Shut down Autofill Assistant at the end of the current script.
   virtual void Shutdown() = 0;
 

components/autofill_assistant/browser/actions/mock_action_delegate.cc

@@ -4,6 +4,8 @@
 
 #include "components/autofill_assistant/browser/actions/mock_action_delegate.h"
 
+#include "url/gurl.h"
+
 namespace autofill_assistant {
 
 MockActionDelegate::MockActionDelegate() = default;

components/autofill_assistant/browser/actions/mock_action_delegate.h

@@ -5,6 +5,9 @@
 #ifndef COMPONENTS_AUTOFILL_ASSISTANT_BROWSER_ACTIONS_MOCK_ACTION_DELEGATE_H_
 #define COMPONENTS_AUTOFILL_ASSISTANT_BROWSER_ACTIONS_MOCK_ACTION_DELEGATE_H_
 
+#include <string>
+#include <vector>
+
 #include "base/callback.h"
 #include "components/autofill_assistant/browser/actions/action_delegate.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ -95,6 +98,7 @@ class MockActionDelegate : public ActionDelegate {
                void(const std::vector<std::string>& selectors,
                     NodeProto* node_tree_out,
                     base::OnceCallback<void(bool)> callback));
+  MOCK_METHOD1(LoadURL, void(const GURL& url));
   MOCK_METHOD0(Shutdown, void());
   MOCK_METHOD0(Restart, void());
   MOCK_METHOD0(GetClientMemory, ClientMemory*());

components/autofill_assistant/browser/actions/navigate_action.cc

+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill_assistant/browser/actions/navigate_action.h"
+
+#include <memory>
+#include <utility>
+
+#include "base/callback.h"
+#include "components/autofill_assistant/browser/actions/action_delegate.h"
+#include "url/gurl.h"
+
+namespace autofill_assistant {
+
+NavigateAction::NavigateAction(const ActionProto& proto) : Action(proto) {
+  DCHECK(proto_.has_navigate());
+}
+
+NavigateAction::~NavigateAction() {}
+
+void NavigateAction::ProcessAction(ActionDelegate* delegate,
+                                   ProcessActionCallback callback) {
+  GURL url(proto_.navigate().url());
+  delegate->LoadURL(url);
+  processed_action_proto_ = std::make_unique<ProcessedActionProto>();
+  UpdateProcessedAction(/* status= */ true);
+  std::move(callback).Run(std::move(processed_action_proto_));
+}
+
+}  // namespace autofill_assistant

components/autofill_assistant/browser/actions/navigate_action.h

+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_ASSISTANT_BROWSER_ACTIONS_NAVIGATE_ACTION_H_
+#define COMPONENTS_AUTOFILL_ASSISTANT_BROWSER_ACTIONS_NAVIGATE_ACTION_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "components/autofill_assistant/browser/actions/action.h"
+
+namespace autofill_assistant {
+// An action to display a message.
+class NavigateAction : public Action {
+ public:
+  explicit NavigateAction(const ActionProto& proto);
+  ~NavigateAction() override;
+
+  // Overrides Action:
+  void ProcessAction(ActionDelegate* delegate,
+                     ProcessActionCallback callback) override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(NavigateAction);
+};
+
+}  // namespace autofill_assistant
+#endif  // COMPONENTS_AUTOFILL_ASSISTANT_BROWSER_ACTIONS_NAVIGATE_ACTION_H_

components/autofill_assistant/browser/mock_web_controller.h

@@ -21,6 +21,8 @@ class MockWebController : public WebController {
 
   MOCK_METHOD0(GetUrl, const GURL&());
 
+  MOCK_METHOD1(LoadURL, void(const GURL&));
+
   void ClickElement(const std::vector<std::string>& selectors,
                     base::OnceCallback<void(bool)> callback) override {
     // Transforming callback into a references allows using RunOnceCallback on

components/autofill_assistant/browser/protocol_utils.cc

@@ -10,6 +10,7 @@
 #include "components/autofill_assistant/browser/actions/autofill_action.h"
 #include "components/autofill_assistant/browser/actions/click_action.h"
 #include "components/autofill_assistant/browser/actions/focus_element_action.h"
+#include "components/autofill_assistant/browser/actions/navigate_action.h"
 #include "components/autofill_assistant/browser/actions/reset_action.h"
 #include "components/autofill_assistant/browser/actions/select_option_action.h"
 #include "components/autofill_assistant/browser/actions/stop_action.h"
@@ -176,6 +177,10 @@ bool ProtocolUtils::ParseActions(
         actions->emplace_back(std::make_unique<SelectOptionAction>(action));
         break;
       }
+      case ActionProto::ActionInfoCase::kNavigate: {
+        actions->emplace_back(std::make_unique<NavigateAction>(action));
+        break;
+      }
       case ActionProto::ActionInfoCase::kStop: {
         actions->emplace_back(std::make_unique<StopAction>(action));
         break;

components/autofill_assistant/browser/script_executor.cc

@@ -115,6 +115,10 @@ void ScriptExecutor::BuildNodeTree(const std::vector<std::string>& selectors,
                                                std::move(callback));
 }
 
+void ScriptExecutor::LoadURL(const GURL& url) {
+  delegate_->GetWebController()->LoadURL(url);
+}
+
 void ScriptExecutor::Shutdown() {
   at_end_ = SHUTDOWN;
 }

components/autofill_assistant/browser/script_executor.h

@@ -80,6 +80,7 @@ class ScriptExecutor : public ActionDelegate {
   void BuildNodeTree(const std::vector<std::string>& selectors,
                      NodeProto* node_tree_out,
                      base::OnceCallback<void(bool)> callback) override;
+  void LoadURL(const GURL& url) override;
   void Shutdown() override;
   void Restart() override;
   ClientMemory* GetClientMemory() override;

components/autofill_assistant/browser/service.proto

@@ -187,6 +187,7 @@ message ActionProto {
   oneof action_info {
     ClickProto click = 5;
     SelectOptionProto select_option = 7;
+    NavigateProto navigate = 9;
     TellProto tell = 11;
     FocusElementProto focus_element = 12;
     WaitForDomProto wait_for_dom = 19;
@@ -357,6 +358,11 @@ message UploadDomProto {
   optional ElementReferenceProto tree_root = 1;
 }
 
+// Load the given URL in the current tab.
+message NavigateProto {
+  optional string url = 1;
+}
+
 // Resets Autofill Assistant: clears any state and server payload.
 message ResetProto {}
 

components/autofill_assistant/browser/web_controller.cc

@@ -4,6 +4,8 @@
 
 #include "components/autofill_assistant/browser/web_controller.h"
 
+#include <utility>
+
 #include "base/callback.h"
 #include "base/logging.h"
 #include "components/autofill/content/browser/content_autofill_driver.h"
@@ -83,6 +85,11 @@ const GURL& WebController::GetUrl() {
   return web_contents_->GetLastCommittedURL();
 }
 
+void WebController::LoadURL(const GURL& url) {
+  web_contents_->GetController().LoadURLWithParams(
+      content::NavigationController::LoadURLParams(url));
+}
+
 void WebController::ClickElement(const std::vector<std::string>& selectors,
                                  base::OnceCallback<void(bool)> callback) {
   DCHECK(!selectors.empty());

components/autofill_assistant/browser/web_controller.h

@@ -45,6 +45,10 @@ class WebController {
   // Returns the last committed URL of the associated |web_contents_|.
   virtual const GURL& GetUrl();
 
+  // Load |url| in the current tab. Returns immediately, before the new page has
+  // been loaded.
+  virtual void LoadURL(const GURL& url);
+
   // Perform a mouse left button click on the element given by |selectors| and
   // return the result through callback.
   // CSS selectors in |selectors| are ordered from top frame to the frame

components/autofill_assistant/browser/web_controller_browsertest.cc

@@ -14,6 +14,8 @@
 
 namespace autofill_assistant {
 
+const char* kTargetWebsitePath = "/autofill_assistant_target_website.html";
+
 class WebControllerBrowserTest : public content::ContentBrowserTest {
  public:
   WebControllerBrowserTest() {}
@@ -26,9 +28,8 @@ class WebControllerBrowserTest : public content::ContentBrowserTest {
     http_server_->ServeFilesFromSourceDirectory(
         "components/test/data/autofill_assistant");
     ASSERT_TRUE(http_server_->Start());
-    ASSERT_TRUE(NavigateToURL(
-        shell(),
-        http_server_->GetURL("/autofill_assistant_target_website.html")));
+    ASSERT_TRUE(
+        NavigateToURL(shell(), http_server_->GetURL(kTargetWebsitePath)));
     web_controller_ =
         WebController::CreateForWebContents(shell()->web_contents());
   }
@@ -200,9 +201,11 @@ class WebControllerBrowserTest : public content::ContentBrowserTest {
     std::move(done_callback).Run();
   }
 
+ protected:
+  std::unique_ptr<WebController> web_controller_;
+
  private:
   std::unique_ptr<net::EmbeddedTestServer> http_server_;
-  std::unique_ptr<WebController> web_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(WebControllerBrowserTest);
 };
@@ -398,4 +401,11 @@ IN_PROC_BROWSER_TEST_F(WebControllerBrowserTest, GetAndSetFieldValue) {
   EXPECT_FALSE(SetFieldValue(selectors, "foobar"));
 }
 
+IN_PROC_BROWSER_TEST_F(WebControllerBrowserTest, NavigateToUrl) {
+  EXPECT_EQ(kTargetWebsitePath, web_controller_->GetUrl().path());
+  web_controller_->LoadURL(GURL(url::kAboutBlankURL));
+  WaitForLoadStop(shell()->web_contents());
+  EXPECT_EQ(url::kAboutBlankURL, web_controller_->GetUrl().spec());
+}
+
 }  // namespace