Disallow sharing PlayFiles root

Sharing Play files root also shares Downloads which may
be unexpected.

UI Test in crosreview.com/1619443 since it is unlikely to merge
so well.

Bug: 958840
Change-Id: I0b199dc65698aa391c52021a1106a4d7631802ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616703
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661252}

ui/file_manager/file_manager/background/js/crostini.js

@@ -243,6 +243,13 @@ CrostiniImpl.prototype.canSharePath = function(vmName, entry, persist) {
     return false;
   }
 
+  // TODO(crbug.com/958840): Sharing Play files root is disallowed until
+  // we can ensure it will not also share Downloads.
+  if (root === VolumeManagerCommon.RootType.ANDROID_FILES &&
+      entry.fullPath === '/') {
+    return false;
+  }
+
   // Special case to disallow PluginVm sharing on /MyFiles/PluginVm and
   // subfolders since it gets shared by default.
   if (vmName === CrostiniImpl.PLUGIN_VM &&

ui/file_manager/file_manager/background/js/crostini_unittest.js

@@ -171,14 +171,22 @@ function testCanSharePath() {
   setDriveFsEnabled(true);
   // TODO(crbug.com/917920): Add computers_grand_root and computers when DriveFS
   // enforces allowed write paths.
+
   const allowed = [
     'downloads', 'removable', 'android_files', 'drive',
     'shared_drives_grand_root', 'team_drive'
   ];
   for (const type of allowed) {
     volumeManagerRootType = type;
-    assertTrue(crostini.canSharePath('vm', root, true));
-    assertTrue(crostini.canSharePath('vm', root, false));
+    // TODO(crbug.com/958840): Sharing Play files root is disallowed until
+    // we can ensure it will not also share Downloads.
+    if (type === 'android_files') {
+      assertFalse(crostini.canSharePath('vm', root, true));
+      assertFalse(crostini.canSharePath('vm', root, false));
+    } else {
+      assertTrue(crostini.canSharePath('vm', root, true));
+      assertTrue(crostini.canSharePath('vm', root, false));
+    }
     assertFalse(crostini.canSharePath('vm', rootFile, true));
     assertTrue(crostini.canSharePath('vm', rootFile, false));
     assertTrue(crostini.canSharePath('vm', rootFolder, true));

ui/file_manager/file_manager/test/crostini_share.js

@@ -211,17 +211,9 @@ shareBase.testSharePaths = async (vmName, vmNameSelector, enumUma, done) => {
       givePermission + 'files in your Google Drive. ' +
           'Changes will sync to your other devices.');
 
-  // Verify share with dialog for Play files.
-  test.mountAndroidFiles();
-  await test.waitForElement(androidRoot);
-  await shareBase.verifyShareWithDialog(
-      'Android files', androidRoot, menuShareWithDirTree, shareWithDirTree,
-      givePermission + 'files in the Play files folder');
-
   // Reset Linux files and Play files back to unmounted.
   chrome.fileManagerPrivate.removeMount('crostini');
   await test.waitForElement(fakeLinuxFiles);
-  chrome.fileManagerPrivate.removeMount('android_files');
 
   // Restore fmp.*.
   chrome.fileManagerPrivate.sharePathsWithCrostini = oldSharePaths;

ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js

@@ -810,7 +810,6 @@
    */
   testcase.dirContextMenuPlayFiles = async () => {
     const playFilesMenus = [
-      ['#share-with-linux', true],
       ['#new-folder', false],
     ];
     const folderMenus = [