Commit 3d79357f authored by dmazzoni's avatar dmazzoni Committed by Commit bot

Filter out AX window events to make tests less flaky.

The DumpAccessibilityEvent* tests sometimes fail when
there's an event on a ROLE_SYSTEM_WINDOW, but these
events are out of our control for a non-interactive
test, so just filter them out.

BUG=none

Review URL: https://codereview.chromium.org/1114683002

Cr-Commit-Position: refs/heads/master@{#327415}
parent 44bdc473
...@@ -206,6 +206,13 @@ void AccessibilityEventRecorderWin::OnWinEventHook( ...@@ -206,6 +206,13 @@ void AccessibilityEventRecorderWin::OnWinEventHook(
iaccessible->get_accState(childid_self, state.Receive()); iaccessible->get_accState(childid_self, state.Receive());
int ia_state = V_I4(state.ptr()); int ia_state = V_I4(state.ptr());
// Avoid flakiness. Events fired on a WINDOW are out of the control
// of a test.
if (role.type() == VT_I4 && ROLE_SYSTEM_WINDOW == V_I4(role.ptr())) {
VLOG(1) << "Ignoring event " << event << " on ROLE_SYSTEM_WINDOW";
return;
}
// Avoid flakiness. The "offscreen" state depends on whether the browser // Avoid flakiness. The "offscreen" state depends on whether the browser
// window is frontmost or not, and "hottracked" depends on whether the // window is frontmost or not, and "hottracked" depends on whether the
// mouse cursor happens to be over the element. // mouse cursor happens to be over the element.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment