Commit 3d7a94bb authored by dtrainor@chromium.org's avatar dtrainor@chromium.org

This fixes the component build.

Need to pass the CONFIGURATION_NAME through to the push python libs.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23936004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222171 0039d316-1c4b-4281-b951-d872f2087c98
parent e2048b6d
...@@ -21,6 +21,7 @@ from util import md5_check ...@@ -21,6 +21,7 @@ from util import md5_check
BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..') BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..')
sys.path.append(BUILD_ANDROID_DIR) sys.path.append(BUILD_ANDROID_DIR)
from pylib import constants
from pylib.utils import apk_helper from pylib.utils import apk_helper
def GetNewMetadata(device, apk_package): def GetNewMetadata(device, apk_package):
...@@ -62,6 +63,8 @@ def main(argv): ...@@ -62,6 +63,8 @@ def main(argv):
help='Path to build device configuration.') help='Path to build device configuration.')
parser.add_option('--stamp', parser.add_option('--stamp',
help='Path to touch on success.') help='Path to touch on success.')
parser.add_option('--configuration-name',
help='The build CONFIGURATION_NAME')
options, _ = parser.parse_args() options, _ = parser.parse_args()
device = build_device.GetBuildDeviceFromPath( device = build_device.GetBuildDeviceFromPath(
...@@ -69,6 +72,8 @@ def main(argv): ...@@ -69,6 +72,8 @@ def main(argv):
if not device: if not device:
return return
constants.SetBuildType(options.configuration_name)
serial_number = device.GetSerialNumber() serial_number = device.GetSerialNumber()
apk_package = apk_helper.GetPackageName(options.apk_path) apk_package = apk_helper.GetPackageName(options.apk_path)
......
...@@ -23,6 +23,7 @@ from util import md5_check ...@@ -23,6 +23,7 @@ from util import md5_check
BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..') BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..')
sys.path.append(BUILD_ANDROID_DIR) sys.path.append(BUILD_ANDROID_DIR)
from pylib import constants
from pylib.utils import apk_helper from pylib.utils import apk_helper
def RunShellCommand(device, cmd): def RunShellCommand(device, cmd):
...@@ -93,11 +94,14 @@ def main(argv): ...@@ -93,11 +94,14 @@ def main(argv):
parser.add_option('--stamp', help='Path to touch on success.') parser.add_option('--stamp', help='Path to touch on success.')
parser.add_option('--build-device-configuration', parser.add_option('--build-device-configuration',
help='Path to build device configuration.') help='Path to build device configuration.')
parser.add_option('--configuration-name',
help='The build CONFIGURATION_NAME')
options, _ = parser.parse_args() options, _ = parser.parse_args()
required_options = ['apk', 'libraries_json', 'script_host_path', required_options = ['apk', 'libraries_json', 'script_host_path',
'script_device_path', 'target_dir'] 'script_device_path', 'target_dir', 'configuration_name']
build_utils.CheckOptions(options, parser, required=required_options) build_utils.CheckOptions(options, parser, required=required_options)
constants.SetBuildType(options.configuration_name)
CreateSymlinkScript(options) CreateSymlinkScript(options)
TriggerSymlinkScript(options) TriggerSymlinkScript(options)
......
...@@ -13,6 +13,11 @@ import optparse ...@@ -13,6 +13,11 @@ import optparse
import os import os
import sys import sys
BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), os.pardir)
sys.path.append(BUILD_ANDROID_DIR)
from pylib import constants
from util import build_device from util import build_device
from util import build_utils from util import build_utils
from util import md5_check from util import md5_check
...@@ -57,10 +62,13 @@ def main(argv): ...@@ -57,10 +62,13 @@ def main(argv):
parser.add_option('--stamp', help='Path to touch on success.') parser.add_option('--stamp', help='Path to touch on success.')
parser.add_option('--build-device-configuration', parser.add_option('--build-device-configuration',
help='Path to build device configuration.') help='Path to build device configuration.')
parser.add_option('--configuration-name',
help='The build CONFIGURATION_NAME')
options, _ = parser.parse_args() options, _ = parser.parse_args()
required_options = ['libraries_dir', 'device_dir', 'libraries_json'] required_options = ['libraries_dir', 'device_dir', 'libraries_json']
build_utils.CheckOptions(options, parser, required=required_options) build_utils.CheckOptions(options, parser, required=required_options)
constants.SetBuildType(options.configuration_name)
DoPush(options) DoPush(options)
......
...@@ -15,6 +15,7 @@ ...@@ -15,6 +15,7 @@
# 'libraries_source_dir': 'location where stripped libraries are stored' # 'libraries_source_dir': 'location where stripped libraries are stored'
# 'device_library_dir': 'location on the device where to put pushed libraries', # 'device_library_dir': 'location on the device where to put pushed libraries',
# 'push_stamp': 'file to touch when the action is complete' # 'push_stamp': 'file to touch when the action is complete'
# 'configuration_name': 'The build CONFIGURATION_NAME'
# }, # },
# 'includes': [ '../../build/android/push_libraries.gypi' ], # 'includes': [ '../../build/android/push_libraries.gypi' ],
# ], # ],
...@@ -41,5 +42,6 @@ ...@@ -41,5 +42,6 @@
'--device-dir=<(device_library_dir)', '--device-dir=<(device_library_dir)',
'--libraries-json=<(ordered_libraries_file)', '--libraries-json=<(ordered_libraries_file)',
'--stamp=<(push_stamp)', '--stamp=<(push_stamp)',
'--configuration-name=<(configuration_name)',
], ],
} }
...@@ -247,6 +247,7 @@ ...@@ -247,6 +247,7 @@
'libraries_top_dir': '<(intermediate_dir)/lib.stripped', 'libraries_top_dir': '<(intermediate_dir)/lib.stripped',
'libraries_source_dir': '<(libraries_top_dir)/lib/<(android_app_abi)', 'libraries_source_dir': '<(libraries_top_dir)/lib/<(android_app_abi)',
'device_library_dir': '<(device_intermediate_dir)/lib.stripped', 'device_library_dir': '<(device_intermediate_dir)/lib.stripped',
'configuration_name': '<(CONFIGURATION_NAME)',
}, },
'dependencies': [ 'dependencies': [
'<(DEPTH)/tools/android/md5sum/md5sum.gyp:md5sum', '<(DEPTH)/tools/android/md5sum/md5sum.gyp:md5sum',
...@@ -278,6 +279,7 @@ ...@@ -278,6 +279,7 @@
'--target-dir=<(device_library_dir)', '--target-dir=<(device_library_dir)',
'--apk=<(incomplete_apk_path)', '--apk=<(incomplete_apk_path)',
'--stamp=<(link_stamp)', '--stamp=<(link_stamp)',
'--configuration-name=<(CONFIGURATION_NAME)',
], ],
}, },
], ],
...@@ -371,6 +373,7 @@ ...@@ -371,6 +373,7 @@
'--apk-path=<(incomplete_apk_path)', '--apk-path=<(incomplete_apk_path)',
'--build-device-configuration=<(build_device_config_path)', '--build-device-configuration=<(build_device_config_path)',
'--install-record=<(apk_install_record)', '--install-record=<(apk_install_record)',
'--configuration-name=<(CONFIGURATION_NAME)',
], ],
}, },
], ],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment