Commit 3d82637f authored by Tommy C. Li's avatar Tommy C. Li Committed by Commit Bot

Omnibox: Query in Omnibox - Remove Page Info unelision on Desktop

Removes the page info popup triggering unelision on Desktop.

Users found it more surprising than useful. We are adding other, more
explicit methods of unelision.

This CL is a simple revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1265497

Bug: 874592, 894862
Change-Id: Ia1ebc7de91bb69f0aac9df22235b4ea24e7c0e93
Reviewed-on: https://chromium-review.googlesource.com/c/1332266Reviewed-by: default avatarKevin Bailey <krb@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608037}
parent 5337562e
...@@ -1260,14 +1260,6 @@ bool LocationBarView::ShowPageInfoDialog() { ...@@ -1260,14 +1260,6 @@ bool LocationBarView::ShowPageInfoDialog() {
contents, entry->GetVirtualURL(), security_info); contents, entry->GetVirtualURL(), security_info);
bubble->SetHighlightedButton(location_icon_view()); bubble->SetHighlightedButton(location_icon_view());
bubble->GetWidget()->Show(); bubble->GetWidget()->Show();
// When the user opens the page info bubble, we also expose the full URL,
// temporarily disabling Steady State Elisions and Query in Omnibox.
// We are currently gating this behavior on the Query in Omnibox flag, since
// it's still under active experimentation.
if (base::FeatureList::IsEnabled(omnibox::kQueryInOmnibox))
omnibox_view()->model()->Unelide(true /* exit_query_in_omnibox */);
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment