Commit 3dacac79 authored by Oleh Prypin's avatar Oleh Prypin Committed by Commit Bot

Ignore "Synchronous XHR in page dismissal" error thrown by AppRTC

https://github.com/webrtc/apprtc/blob/20cdd7652d58c9cf47ef92ba0190a5505760dc05/src/web_app/js/call.js#L159
sends an XHR on page close which is now an error in Chromium. Ignoring the error doesn't cause any problems, especially for the purpose of this test, so until a real fix is made, this is a simple way to un-break tests.
(https://ci.chromium.org/p/chromium/g/chromium.webrtc)

Bug: 918871
Change-Id: I29497a39424a1c54e7b6875edc0cb896663221ea
Reviewed-on: https://chromium-review.googlesource.com/c/1396019Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619943}
parent 827deeb5
...@@ -89,6 +89,10 @@ bool JavascriptErrorDetectingLogHandler(int severity, ...@@ -89,6 +89,10 @@ bool JavascriptErrorDetectingLogHandler(int severity,
if (file == NULL || std::string("CONSOLE") != file) if (file == NULL || std::string("CONSOLE") != file)
return false; return false;
// TODO(crbug.com/918871): Fix AppRTC and stop ignoring this error.
if (str.find("Synchronous XHR in page dismissal") != std::string::npos)
return false;
bool contains_uncaught = str.find("\"Uncaught ") != std::string::npos; bool contains_uncaught = str.find("\"Uncaught ") != std::string::npos;
if (severity == logging::LOG_ERROR || if (severity == logging::LOG_ERROR ||
(severity == logging::LOG_INFO && contains_uncaught)) { (severity == logging::LOG_INFO && contains_uncaught)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment