Use IncognitoTabModelObserver to break IncognitoTabModel->.incognito
Two new classes IncognitoNotificationPresenceController and IncognitoProfileDestroyer now bind the TabModelSelector to the .incognito package, controlling respectively the incognito notification and the incognito Profile destruction. Since TabModelSelectorBase creates the TabModels only after native load, it acts as a relay for the events. It is changed to recognize that there are two TabModels, one normal and one incognito, so it can observe the incognito one. Splitting IncognitoTabModel into interface and impl keeps tests from having to depend on IncognitoTabModelImpl. Bug: 1109013 Change-Id: I697f8422777ec42b44ddf19af8abb82702e136a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343790 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#798298}
Showing
Please register or sign in to comment