remove WS_THICKFRAME for full screen in pre 1903 Windows

Not doing so caused issues with playing videos in full screen mode on
older versions of Windows, when we stopped removing WS_THICKFRAME in
crrev.com/c/1972258.

Bug: 1014720,1141059
Change-Id: I57b01051c457b35b37c465ce3b38d60bf896c32e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510354Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824543}

ui/base/BUILD.gn

@@ -1168,6 +1168,7 @@ if (is_win) {
       "fullscreen_win.cc",
       "fullscreen_win.h",
     ]
+    deps = [ ":base" ]
   }
 }
 

ui/base/fullscreen_win.cc

@@ -8,6 +8,8 @@
 
 #include <shellapi.h>
 
+#include "base/win/windows_version.h"
+
 namespace ui {
 
 namespace {
@@ -51,7 +53,16 @@ bool IsFullScreenWindowMode() {
   // style should not have WS_EX_WINDOWEDGE and WS_EX_TOOLWINDOW.
   LONG style = ::GetWindowLong(wnd, GWL_STYLE);
   LONG ext_style = ::GetWindowLong(wnd, GWL_EXSTYLE);
-  return !((style & WS_DLGFRAME) ||
+  LONG styles_not_to_have = WS_DLGFRAME;
+
+  // Chrome removes WS_THICKFRAME in older versions of Windows. See
+  // crbug.com/1141059 and crbug.com/1014720. The version here must match the
+  // version checked in ui/views/win/fullscreen_handler.cc's
+  // FullscreenHandler::SetFullscreenImpl.
+  if (base::win::GetVersion() < base::win::Version::WIN10_19H1)
+    styles_not_to_have |= WS_THICKFRAME;
+
+  return !((style & styles_not_to_have) ||
            (ext_style & (WS_EX_WINDOWEDGE | WS_EX_TOOLWINDOW)));
 }
 

ui/views/win/fullscreen_handler.cc

@@ -7,6 +7,7 @@
 #include <memory>
 
 #include "base/win/win_util.h"
+#include "base/win/windows_version.h"
 #include "ui/base/win/shell.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/views/win/scoped_fullscreen_visibility.h"
@@ -71,8 +72,18 @@ void FullscreenHandler::SetFullscreenImpl(bool fullscreen) {
   fullscreen_ = fullscreen;
 
   if (fullscreen_) {
+    LONG styles_to_remove = WS_CAPTION;
+
+    // Not removing WS_THICKFRAME causes an issue with full screen in older
+    // versions of Windows. See crbug.com/1141059 and crbug.com/1014720. The
+    // version here must match the version checked in
+    // ui/base/fullscreen_win.cc's IsFullScreenWindowMode.
+    if (base::win::GetVersion() < base::win::Version::WIN10_19H1)
+      styles_to_remove |= WS_THICKFRAME;
+
     // Set new window style and size.
-    SetWindowLong(hwnd_, GWL_STYLE, saved_window_info_.style & ~WS_CAPTION);
+    SetWindowLong(hwnd_, GWL_STYLE,
+                  saved_window_info_.style & ~styles_to_remove);
     SetWindowLong(
         hwnd_, GWL_EXSTYLE,
         saved_window_info_.ex_style & ~(WS_EX_DLGMODALFRAME | WS_EX_WINDOWEDGE |