Commit 3dfe6892 authored by Vitaly Buka's avatar Vitaly Buka Committed by Commit Bot

Fix FastSharedBufferReaderTest::readAllOverlappingLastSegmentBoundary

GetConsecutiveData may return pointer into internal cache.
However the test always check buffer which accidentally contains the same data
from the previous iteration.

Found compiling with -ftrivial-auto-var-init=pattern

Change-Id: Ib72585fd598d23bac6bcb976d7b3f309536a8376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769232
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Auto-Submit: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690100}
parent aa2c9615
...@@ -145,9 +145,9 @@ TEST(FastSharedBufferReaderTest, readAllOverlappingLastSegmentBoundary) { ...@@ -145,9 +145,9 @@ TEST(FastSharedBufferReaderTest, readAllOverlappingLastSegmentBoundary) {
SegmentReaders reader_struct(data); SegmentReaders reader_struct(data);
for (auto segment_reader : reader_struct.segment_readers) { for (auto segment_reader : reader_struct.segment_readers) {
FastSharedBufferReader reader(segment_reader); FastSharedBufferReader reader(segment_reader);
char buffer[kDataSize]; char buffer[kDataSize] = {};
reader.GetConsecutiveData(0, kDataSize, buffer); const char* result = reader.GetConsecutiveData(0, kDataSize, buffer);
ASSERT_FALSE(memcmp(buffer, reference_data, kDataSize)); ASSERT_FALSE(memcmp(result, reference_data, kDataSize));
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment