Commit 3e3d53ae authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

[filesapp] Add common util dep to multi-menu and multi-menu-button

multi_menu.js and multi_menu_button.js need CSS stylistic variation in
files-ng to account for the action bar tap-target gap.

Current files-app uses CSS to do provide gap after CL:2298847, however
that caused #tasks-menu to move too far down when used as a submenu.

Add common util dep so we can switch on files-ng and change the margin
top, depending on whether we are showing a submenu or not.

Bug: 1066727
Change-Id: Iaa8fe321f6b1f55c619ab212c5812f2108d4d0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299672Reviewed-by: default avatarAlex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788905}
parent 659c2747
...@@ -436,6 +436,8 @@ js_library("location_line") { ...@@ -436,6 +436,8 @@ js_library("location_line") {
js_library("multi_menu") { js_library("multi_menu") {
deps = [ deps = [
# TODO(files-ng): remove util dep when the files-ng flag is removed.
"//ui/file_manager/file_manager/common/js:util",
"//ui/webui/resources/js:event_tracker", "//ui/webui/resources/js:event_tracker",
"//ui/webui/resources/js/cr/ui:menu", "//ui/webui/resources/js/cr/ui:menu",
"//ui/webui/resources/js/cr/ui:menu_item", "//ui/webui/resources/js/cr/ui:menu_item",
...@@ -446,6 +448,8 @@ js_library("multi_menu") { ...@@ -446,6 +448,8 @@ js_library("multi_menu") {
js_library("multi_menu_button") { js_library("multi_menu_button") {
deps = [ deps = [
# TODO(files-ng): remove util dep when the files-ng flag is removed.
"//ui/file_manager/file_manager/common/js:util",
"//ui/webui/resources/js:event_tracker", "//ui/webui/resources/js:event_tracker",
"//ui/webui/resources/js/cr/ui:menu", "//ui/webui/resources/js/cr/ui:menu",
"//ui/webui/resources/js/cr/ui:menu_button", "//ui/webui/resources/js/cr/ui:menu_button",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment