Commit 3e4eb113 authored by maruel@chromium.org's avatar maruel@chromium.org

Remove BUG= and TEST= checks from upload commit presubmit check.

Fix PRESUBMIT.py to exclude Makefile.

BUG=none
TEST=presubmit check is less noisy

Review URL: http://codereview.chromium.org/5976009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
parent d6ba5a0b
...@@ -9,10 +9,11 @@ for more details about the presubmit API built into gcl. ...@@ -9,10 +9,11 @@ for more details about the presubmit API built into gcl.
""" """
_EXCLUDED_PATHS = ( _EXCLUDED_PATHS = (
r"breakpad[\\\/].*", r"^breakpad[\\\/].*",
r"net/tools/spdyshark/[\\\/].*", r"^net/tools/spdyshark/[\\\/].*",
r"skia[\\\/].*", r"^skia[\\\/].*",
r"v8[\\\/].*", r"^v8[\\\/].*",
r".*MakeFile$",
) )
_TEXT_FILES = ( _TEXT_FILES = (
...@@ -106,10 +107,6 @@ def _CommonChecks(input_api, output_api): ...@@ -106,10 +107,6 @@ def _CommonChecks(input_api, output_api):
input_api, output_api, source_file_filter=sources)) input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api, source_file_filter=sources)) input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle( results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files)) input_api, output_api, source_file_filter=text_files))
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes( results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
...@@ -171,6 +168,10 @@ def CheckChangeOnCommit(input_api, output_api): ...@@ -171,6 +168,10 @@ def CheckChangeOnCommit(input_api, output_api):
'http://build.chromium.org/p/chromium/json/builders?filter=1', 'http://build.chromium.org/p/chromium/json/builders?filter=1',
6, 6,
IGNORED_BUILDERS)) IGNORED_BUILDERS))
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
return results return results
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment