Commit 3e54f396 authored by tonyg@chromium.org's avatar tonyg@chromium.org

[Telemetry] Remove arbitrary sleep in record_wpr.

This fixes an old TODO, makes recording more robust and improves the
cycle time of the record_wpr unittests from about 33s -> 26s on my MBP.

BUG=388256

Review URL: https://codereview.chromium.org/465213002

Cr-Commit-Position: refs/heads/master@{#289225}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289225 0039d316-1c4b-4281-b951-d872f2087c98
parent 547791f6
#!/usr/bin/env python
# Copyright 2012 The Chromium Authors. All rights reserved. # Copyright 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
import logging import logging
import sys import sys
import time
from telemetry import benchmark from telemetry import benchmark
from telemetry.core import browser_options from telemetry.core import browser_options
from telemetry.core import discover from telemetry.core import discover
from telemetry.core import util
from telemetry.core import wpr_modes from telemetry.core import wpr_modes
from telemetry.page import page_runner from telemetry.page import page_runner
from telemetry.page import page_set from telemetry.page import page_set
...@@ -52,13 +52,7 @@ class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223 ...@@ -52,13 +52,7 @@ class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
def RunPage(self, page, tab, results): def RunPage(self, page, tab, results):
tab.WaitForDocumentReadyStateToBeComplete() tab.WaitForDocumentReadyStateToBeComplete()
util.WaitFor(tab.HasReachedQuiescence, 30)
# When recording, sleep to catch any resources that load post-onload.
# TODO(tonyg): This should probably monitor resource timing for activity
# and sleep until 2s since the last network event with some timeout like
# 20s. We could wrap this up as WaitForNetworkIdle() and share with the
# speed index metric.
time.sleep(3)
if self.page_test: if self.page_test:
self._action_name_to_run = self.page_test.action_name_to_run self._action_name_to_run = self.page_test.action_name_to_run
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment