Commit 3e65b0ff authored by Ryan Daum's avatar Ryan Daum Committed by Commit Bot

[chromecast] Remove setColorInversion from window manager

We no longer want to perform this operation through the WindowManager
since that does software color conversion which causes a render pass
(leading to issues with inversion while playing video, among other
things).

Color inversion on cast display devices is now performed through
internal hardware-specific methods.

Bug: internal b/120272088
Test: manual test on device
Change-Id: I60e4b59b8fc90fc2cbfe8f847d0d99fac4606647
Reviewed-on: https://chromium-review.googlesource.com/c/1357013
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Reviewed-by: default avatarAlex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612699}
parent 3f40244c
......@@ -70,9 +70,6 @@ class CastWindowManager {
// Remove the registration of a system gesture events handler.
virtual void RemoveGestureHandler(CastGestureHandler* handler) = 0;
// Enable/Disable color inversion.
virtual void SetColorInversion(bool enable) = 0;
// Enable/disable the handling of all touch events.
virtual void SetTouchInputDisabled(bool disabled) = 0;
......
......@@ -318,12 +318,6 @@ void CastWindowManagerAura::CastWindowManagerAura::RemoveGestureHandler(
system_gesture_dispatcher_->RemoveGestureHandler(handler);
}
void CastWindowManagerAura::CastWindowManagerAura::SetColorInversion(
bool enable) {
DCHECK(window_tree_host_);
window_tree_host_->window()->layer()->SetLayerInverted(enable);
}
CastGestureHandler* CastWindowManagerAura::GetGestureHandler() const {
return system_gesture_dispatcher_.get();
}
......
......@@ -71,8 +71,6 @@ class CastWindowManagerAura : public CastWindowManager,
void RemoveGestureHandler(CastGestureHandler* handler) override;
void SetColorInversion(bool enable) override;
CastWindowTreeHost* window_tree_host() const;
CastGestureHandler* GetGestureHandler() const;
......
......@@ -22,8 +22,6 @@ gfx::NativeView CastWindowManagerDefault::GetRootWindow() {
return nullptr;
}
void CastWindowManagerDefault::SetColorInversion(bool enable) {}
// Register a new handler for system gesture events.
void CastWindowManagerDefault::AddGestureHandler(CastGestureHandler* handler) {}
// Remove the registration of a system gesture events handler.
......
......@@ -28,8 +28,6 @@ class CastWindowManagerDefault : public CastWindowManager {
void RemoveGestureHandler(CastGestureHandler* handler) override;
void SetColorInversion(bool enable) override;
void SetTouchInputDisabled(bool disabled) override;
void AddTouchActivityObserver(CastTouchActivityObserver* observer) override;
void RemoveTouchActivityObserver(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment