[FullRoll] Add a new Feature: "Modern Full Roll".

Adds a new Feature to chrome://flags for Android to use to enable a
modern version of the Full-roll animation.

BUG=856792

Change-Id: I2b2369f509dd809e12c03bf4ac79c58e764799a4
Reviewed-on: https://chromium-review.googlesource.com/1116186
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571309}

chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java

@@ -169,6 +169,7 @@ public abstract class ChromeFeatureList {
     public static final String CHROME_MODERN_ALTERNATE_CARD_LAYOUT =
             "ChromeModernAlternateCardLayout";
     public static final String CHROME_MODERN_DESIGN = "ChromeModernDesign";
+    public static final String CHROME_MODERN_FULL_ROLL = "ChromeModernFullRoll";
     public static final String CHROME_SMART_SELECTION = "ChromeSmartSelection";
     public static final String CLEAR_OLD_BROWSING_DATA = "ClearOldBrowsingData";
     public static final String CLIPBOARD_CONTENT_SETTING = "ClipboardContentSetting";

chrome/browser/about_flags.cc

@@ -1893,6 +1893,10 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kChromeModernAlternateCardLayoutName,
      flag_descriptions::kChromeModernAlternateCardLayoutDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(chrome::android::kChromeModernAlternateCardLayout)},
+    {"enable-chrome-modern-full-roll",
+     flag_descriptions::kChromeModernFullRollName,
+     flag_descriptions::kChromeModernFullRollDescription, kOsAndroid,
+     FEATURE_VALUE_TYPE(chrome::android::kChromeModernFullRoll)},
     {"force-enable-home-page-button", flag_descriptions::kHomePageButtonName,
      flag_descriptions::kHomePageButtonDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(chrome::android::kHomePageButtonForceEnabled)},

chrome/browser/android/chrome_feature_list.cc

@@ -83,6 +83,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
     &kChromeMemexFeature,
     &kChromeModernAlternateCardLayout,
     &kChromeModernDesign,
+    &kChromeModernFullRoll,
     &kCommandLineOnNonRooted,
     &kContentSuggestionsScrollToLoad,
     &kContentSuggestionsSettings,
@@ -220,6 +221,9 @@ const base::Feature kChromeModernAlternateCardLayout{
 const base::Feature kChromeModernDesign{"ChromeModernDesign",
                                         base::FEATURE_DISABLED_BY_DEFAULT};
 
+const base::Feature kChromeModernFullRoll{"ChromeModernFullRoll",
+                                          base::FEATURE_DISABLED_BY_DEFAULT};
+
 const base::Feature kChromeSmartSelection{"ChromeSmartSelection",
                                           base::FEATURE_ENABLED_BY_DEFAULT};
 

chrome/browser/android/chrome_feature_list.h

@@ -29,6 +29,7 @@ extern const base::Feature kChromeHomeSwipeLogicVelocity;
 extern const base::Feature kChromeMemexFeature;
 extern const base::Feature kChromeModernAlternateCardLayout;
 extern const base::Feature kChromeModernDesign;
+extern const base::Feature kChromeModernFullRoll;
 extern const base::Feature kChromeSmartSelection;
 extern const base::Feature kCommandLineOnNonRooted;
 extern const base::Feature kContentSuggestionsScrollToLoad;

chrome/browser/flag_descriptions.cc

@@ -2088,6 +2088,10 @@ const char kChromeModernDesignDescription[] =
     "Enable modern design for Chrome. Chrome must be restarted twice for this "
     "flag to take effect.";
 
+const char kChromeModernFullRollName[] = "Chrome Modern Full-Roll";
+const char kChromeModernFullRollDescription[] =
+    "Enable modern full-roll animation for Chrome.";
+
 const char kChromeMemexName[] = "Chrome Memex";
 const char kChromeMemexDescription[] =
     "Enables Chrome Memex homepage on Android. Restricted to opted-in "

chrome/browser/flag_descriptions.h

@@ -1272,6 +1272,9 @@ extern const char kChromeModernAlternateCardLayoutDescription[];
 extern const char kChromeModernDesignName[];
 extern const char kChromeModernDesignDescription[];
 
+extern const char kChromeModernFullRollName[];
+extern const char kChromeModernFullRollDescription[];
+
 extern const char kChromeMemexName[];
 extern const char kChromeMemexDescription[];
 

tools/metrics/histograms/enums.xml

@@ -27072,6 +27072,7 @@ from previous Chrome versions.
   <int value="-1817209284" label="PayWithGoogleV1:enabled"/>
   <int value="-1816066138" label="CastAllowAllIPs:enabled"/>
   <int value="-1812579951" label="ContentSuggestionsCategoryRanker:enabled"/>
+  <int value="-1811887751" label="ChromeModernFullRoll:disabled"/>
   <int value="-1811394154" label="disable-webrtc-hw-vp8-encoding"/>
   <int value="-1810294310" label="AndroidPaymentApps:enabled"/>
   <int value="-1808576075" label="SystemTrayUnified:enabled"/>
@@ -27553,6 +27554,7 @@ from previous Chrome versions.
   <int value="-812461825" label="AutofillCreditCardSigninPromo:enabled"/>
   <int value="-810684526"
       label="AutofillToolkitViewsCreditCardDialogsMac:disabled"/>
+  <int value="-810373609" label="ChromeModernFullRoll:enabled"/>
   <int value="-808486493" label="NewWallpaperPicker:disabled"/>
   <int value="-802348444" label="disable-site-engagement-service"/>
   <int value="-798187384" label="try-supported-channel-layouts"/>