Remove SignIn preferences from incognito whitelist.

Preferences related to SignIn are removed from the persistent storage
list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: I03fbc9c62227ca1cbb3b58b9ee2f9ad90df9b586
Reviewed-on: https://chromium-review.googlesource.com/1159367Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580124}

chrome/browser/prefs/pref_service_incognito_whitelist.cc

@@ -27,7 +27,6 @@
 #include "components/rappor/rappor_prefs.h"
 #include "components/reading_list/core/reading_list_pref_names.h"
 #include "components/search_engines/search_engines_pref_names.h"
-#include "components/signin/core/browser/signin_pref_names.h"
 #include "components/spellcheck/browser/pref_names.h"
 #include "components/startup_metric_utils/browser/pref_names.h"
 #include "components/suggestions/suggestions_pref_names.h"
@@ -470,11 +469,6 @@ const char* temporary_incognito_whitelist[] = {
 
     prefs::kGoogleServicesPasswordHash,
 
-#if !defined(OS_ANDROID)
-    prefs::kDiceSigninUserMenuPromoCount, prefs::kSignInPromoStartupCount,
-    prefs::kSignInPromoUserSkipped, prefs::kSignInPromoShowOnFirstRunAllowed,
-#endif
-
 #if !defined(OS_CHROMEOS) && !defined(OS_ANDROID)
     prefs::kCrossDevicePromoOptedOut, prefs::kCrossDevicePromoShouldBeShown,
     prefs::kCrossDevicePromoObservedSingleAccountCookie,
@@ -583,7 +577,7 @@ const char* temporary_incognito_whitelist[] = {
     prefs::kDebuggingFeaturesRequested,
 
 #if defined(OS_CHROMEOS)
-    prefs::kSigninScreenTimezone, prefs::kResolveDeviceTimezoneByGeolocation,
+    prefs::kResolveDeviceTimezoneByGeolocation,
     prefs::kResolveDeviceTimezoneByGeolocationMethod,
     prefs::kSystemTimezoneAutomaticDetectionPolicy,
 #endif  // defined(OS_CHROMEOS)
@@ -639,7 +633,6 @@ const char* temporary_incognito_whitelist[] = {
 
     prefs::kQuickCheckEnabled, prefs::kPacHttpsUrlStrippingEnabled,
     prefs::kBrowserGuestModeEnabled, prefs::kBrowserAddPersonEnabled,
-    prefs::kForceBrowserSignin,
 
     prefs::kCryptAuthDeviceId, prefs::kEasyUnlockHardlockState,
     prefs::kEasyUnlockLocalStateTpmKeys, prefs::kEasyUnlockLocalStateUserPrefs,
@@ -884,23 +877,6 @@ const char* temporary_incognito_whitelist[] = {
     prefs::kDefaultSearchProviderEnabled, prefs::kSearchProviderOverrides,
     prefs::kSearchProviderOverridesVersion, prefs::kCountryIDAtInstall,
 
-// components/signin/core/browser/signin_pref_names.h
-#if defined(OS_CHROMEOS)
-    prefs::kAccountConsistencyMirrorRequired,
-#endif
-    prefs::kAccountIdMigrationState, prefs::kAutologinEnabled,
-    prefs::kGaiaCookieHash, prefs::kGaiaCookieChangedTime,
-    prefs::kGaiaCookiePeriodicReportTime, prefs::kGoogleServicesAccountId,
-    prefs::kGoogleServicesHostedDomain, prefs::kGoogleServicesLastAccountId,
-    prefs::kGoogleServicesLastUsername,
-    prefs::kGoogleServicesSigninScopedDeviceId,
-    prefs::kGoogleServicesUserAccountId, prefs::kGoogleServicesUsername,
-    prefs::kGoogleServicesUsernamePattern, prefs::kReverseAutologinEnabled,
-    prefs::kReverseAutologinRejectedEmailList, prefs::kSignedInTime,
-    prefs::kSigninAllowed, prefs::kTokenServiceDiceCompatible,
-    prefs::kTokenServiceExcludeAllSecondaryAccounts,
-    prefs::kTokenServiceExcludedSecondaryAccounts,
-
     // components/spellcheck/browser/pref_names.h
     spellcheck::prefs::kSpellCheckEnable,
     spellcheck::prefs::kSpellCheckDictionaries,