[ShareButtoninToolbar] use offset icon to compensate for padding issues

screenshot with new icon https://hsv.googleplex.com/6487380976467968

Bug: 1067090
Change-Id: I8eac773b990d99cf45855d37d526b3a7df7ab8f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134578Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756022}

chrome/android/chrome_java_resources.gni

@@ -958,7 +958,7 @@ chrome_java_resources = [
   "java/res/drawable/ic_swap_vert_round.xml",
   "java/res/drawable/ic_sync_error_40dp.xml",
   "java/res/drawable/ic_sync_green_40dp.xml",
-  "java/res/drawable/ic_toolbar_share_24dp.xml",
+  "java/res/drawable/ic_toolbar_share_offset_24dp.xml",
   "java/res/drawable/ic_tv_options_input_settings_rotated_grey.xml",
   "java/res/drawable/ic_videocam_24dp.xml",
   "java/res/drawable/ic_videocam_36dp.xml",

chrome/android/java/res/drawable/ic_toolbar_share_24dp.xml → chrome/android/java/res/drawable/ic_toolbar_share_offset_24dp.xml

@@ -12,15 +12,8 @@
     android:viewportWidth="24"
     android:viewportHeight="24">
   <path
-      android:pathData="m16.5,15.7333c-0.6333,0 -1.2,0.25 -1.6333,0.6417l-5.9417,-3.4583c0.0417,-0.1917 0.075,-0.3833 0.075,-0.5833s-0.0333,-0.3917 -0.075,-0.5833l5.875,-3.425c0.45,0.4167 1.0417,0.675 1.7,0.675 1.3833,0 2.5,-1.1167 2.5,-2.5s-1.1167,-2.5 -2.5,-2.5 -2.5,1.1167 -2.5,2.5c0,0.2 0.0333,0.3917 0.075,0.5833l-5.875,3.425c-0.45,-0.4167 -1.0417,-0.675 -1.7,-0.675 -1.3833,0 -2.5,1.1167 -2.5,2.5 0,1.3833 1.1167,2.5 2.5,2.5 0.6583,0 1.25,-0.2583 1.7,-0.675l5.9333,3.4667c-0.0417,0.175 -0.0667,0.3583 -0.0667,0.5417 0,1.3417 1.0917,2.4333 2.4333,2.4333s2.4333,-1.0917 2.4333,-2.4333c0,-1.3417 -1.0917,-2.4333 -2.4333,-2.4333z"
+      android:pathData="m19.5,15.7333c-0.6333,0 -1.2,0.25 -1.6333,0.6417l-5.9417,-3.4583c0.0417,-0.1917 0.075,-0.3833 0.075,-0.5833s-0.0333,-0.3917 -0.075,-0.5833l5.875,-3.425c0.45,0.4167 1.0417,0.675 1.7,0.675 1.3833,0 2.5,-1.1167 2.5,-2.5s-1.1167,-2.5 -2.5,-2.5 -2.5,1.1167 -2.5,2.5c0,0.2 0.0333,0.3917 0.075,0.5833l-5.875,3.425c-0.45,-0.4167 -1.0417,-0.675 -1.7,-0.675 -1.3833,0 -2.5,1.1167 -2.5,2.5 0,1.3833 1.1167,2.5 2.5,2.5 0.6583,0 1.25,-0.2583 1.7,-0.675l5.9333,3.4667c-0.0417,0.175 -0.0667,0.3583 -0.0667,0.5417 0,1.3417 1.0917,2.4333 2.4333,2.4333s2.4333,-1.0917 2.4333,-2.4333c0,-1.3417 -1.0917,-2.4333 -2.4333,-2.4333z"
       android:fillColor="@color/default_primary_color"
       android:fillType="evenOdd"/>
-  <group>
-    <clip-path android:pathData="m16.5,15.7333c-0.6333,0 -1.2,0.25 -1.6333,0.6417l-5.9417,-3.4583c0.0417,-0.1917 0.075,-0.3833 0.075,-0.5833s-0.0333,-0.3917 -0.075,-0.5833l5.875,-3.425c0.45,0.4167 1.0417,0.675 1.7,0.675 1.3833,0 2.5,-1.1167 2.5,-2.5s-1.1167,-2.5 -2.5,-2.5 -2.5,1.1167 -2.5,2.5c0,0.2 0.0333,0.3917 0.075,0.5833l-5.875,3.425c-0.45,-0.4167 -1.0417,-0.675 -1.7,-0.675 -1.3833,0 -2.5,1.1167 -2.5,2.5 0,1.3833 1.1167,2.5 2.5,2.5 0.6583,0 1.25,-0.2583 1.7,-0.675l5.9333,3.4667c-0.0417,0.175 -0.0667,0.3583 -0.0667,0.5417 0,1.3417 1.0917,2.4333 2.4333,2.4333s2.4333,-1.0917 2.4333,-2.4333c0,-1.3417 -1.0917,-2.4333 -2.4333,-2.4333z M 0,0"/>
-    <path
-        android:pathData="m0,0h24v24h-24z"
-        android:fillColor="@color/default_primary_color"
-        android:fillType="evenOdd"/>
-  </group>
 </vector>
 

chrome/android/java/src/org/chromium/chrome/browser/share/ShareButtonController.java

@@ -103,7 +103,7 @@ public class ShareButtonController implements ButtonDataProvider {
         mContext.registerComponentCallbacks(mComponentCallbacks);
 
         mButtonData = new ButtonData(false,
-                AppCompatResources.getDrawable(mContext, R.drawable.ic_toolbar_share_24dp),
+                AppCompatResources.getDrawable(mContext, R.drawable.ic_toolbar_share_offset_24dp),
                 mOnClickListener, R.string.share, true, null);
 
         mScreenWidthDp = mContext.getResources().getConfiguration().screenWidthDp;