Commit 3eeee6d2 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Run sync_integration_tests on win/asan bots.

One recently re-enabled test fails, so to be able run the whole suite, also:
Revert "Reland "[Sync:USS] Enable more two client bookmarks integration tests""

This reverts commit f846b651.

Reason for revert: One of the tests fails on win/asan, https://crbug.com/875239

Original change's description:
> Reland "[Sync:USS] Enable more two client bookmarks integration tests"
>
> This is a reland of 94d8037b
>
> Original change's description:
> > [Sync:USS] Enable more two client bookmarks integration tests
> >
> > This CL enables more integration tests for bookmarks to run
> > against USS archiecture.
> >
> >
> > Bug: 516866
> > Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f
> > Reviewed-on: https://chromium-review.googlesource.com/1158691
> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580434}
>
> Bug: 516866
> Change-Id: Ia922ab75b92c013cc2e06cb3ec5a549875390316
> Reviewed-on: https://chromium-review.googlesource.com/1161882
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580499}

TBR=mastiz@chromium.org,mamir@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 516866, 875239
Change-Id: I85e49dbfd4e6c2aba675854efb42c4a87d3243b8
Reviewed-on: https://chromium-review.googlesource.com/1180661
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584338}
parent 05d67f11
...@@ -455,7 +455,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -455,7 +455,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Add bookmarks with different name and same URL. // Add bookmarks with different name and same URL.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
SC_DuplicateBookmarksWithSameURL) { SC_DuplicateBookmarksWithSameURL) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1238,7 +1238,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1238,7 +1238,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_TRUE(BookmarksMatchVerifierChecker().Wait()); ASSERT_TRUE(BookmarksMatchVerifierChecker().Wait());
} }
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_BiDirectionalPushAddingBM) { MC_BiDirectionalPushAddingBM) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1256,7 +1256,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1256,7 +1256,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_BiDirectionalPush_AddingSameBMs) { MC_BiDirectionalPush_AddingSameBMs) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1273,14 +1273,14 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1273,14 +1273,14 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_TRUE(BookmarksMatchChecker().Wait()); ASSERT_TRUE(BookmarksMatchChecker().Wait());
} }
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_BootStrapEmptyStateEverywhere) { MC_BootStrapEmptyStateEverywhere) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AwaitQuiescence()); ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
} }
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_Merge_CaseInsensitivity_InNames) { MC_Merge_CaseInsensitivity_InNames) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1302,7 +1302,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1302,7 +1302,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_SimpleMergeOfDifferentBMModels) { MC_SimpleMergeOfDifferentBMModels) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1328,7 +1328,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1328,7 +1328,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_MergeSimpleBMHierarchyUnderBMBar) { MC_MergeSimpleBMHierarchyUnderBMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1351,7 +1351,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1351,7 +1351,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) { MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1369,7 +1369,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1369,7 +1369,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Merge bookmark folders with different bookmarks. // Merge bookmark folders with different bookmarks.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_MergeBMFoldersWithDifferentBMs) { MC_MergeBMFoldersWithDifferentBMs) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1392,7 +1392,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1392,7 +1392,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Merge moderately complex bookmark models. // Merge moderately complex bookmark models.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_MergeDifferentBMModelsModeratelyComplex) { MC_MergeDifferentBMModelsModeratelyComplex) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1433,7 +1433,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1433,7 +1433,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Merge simple bookmark subset under bookmark folder. // Merge simple bookmark subset under bookmark folder.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_MergeSimpleBMHierarchySubsetUnderBMFolder) { MC_MergeSimpleBMHierarchySubsetUnderBMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1458,7 +1458,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1458,7 +1458,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Merge subsets of bookmark under bookmark bar. // Merge subsets of bookmark under bookmark bar.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_MergeSimpleBMHierarchySubsetUnderBookmarkBar) { MC_MergeSimpleBMHierarchySubsetUnderBookmarkBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1482,7 +1482,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1482,7 +1482,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Merge simple bookmark hierarchy under bookmark folder. // Merge simple bookmark hierarchy under bookmark folder.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_Merge_SimpleBMHierarchy_Under_BMFolder) { MC_Merge_SimpleBMHierarchy_Under_BMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1513,7 +1513,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1513,7 +1513,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
// Merge disjoint sets of bookmark hierarchy under bookmark // Merge disjoint sets of bookmark hierarchy under bookmark
// folder. // folder.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BMFolder) { MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1542,8 +1542,8 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1542,8 +1542,8 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Merge disjoint sets of bookmark hierarchy under bookmark bar. // Merge disjoint sets of bookmark hierarchy under bookmark bar.
IN_PROC_BROWSER_TEST_P( IN_PROC_BROWSER_TEST_F(
TwoClientBookmarksSyncTestIncludingUssTests, TwoClientBookmarksSyncTest,
MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BookmarkBar) { MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BookmarkBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1566,7 +1566,7 @@ IN_PROC_BROWSER_TEST_P( ...@@ -1566,7 +1566,7 @@ IN_PROC_BROWSER_TEST_P(
} }
// Merge sets of duplicate bookmarks under bookmark bar. // Merge sets of duplicate bookmarks under bookmark bar.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
MC_Merge_SimpleBMHierarchy_DuplicateBMs_Under_BMBar) { MC_Merge_SimpleBMHierarchy_DuplicateBMs_Under_BMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1627,8 +1627,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) { ...@@ -1627,8 +1627,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) {
} }
// Test adding duplicate folder - Both with different BMs underneath. // Test adding duplicate folder - Both with different BMs underneath.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, MC_DuplicateFolders) {
MC_DuplicateFolders) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1978,8 +1977,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1978,8 +1977,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
// Trigger the server side creation of Synced Bookmarks. Ensure both clients // Trigger the server side creation of Synced Bookmarks. Ensure both clients
// remain syncing afterwards. Add bookmarks to the synced bookmarks folder // remain syncing afterwards. Add bookmarks to the synced bookmarks folder
// and ensure both clients receive the bookmark. // and ensure both clients receive the bookmark.
IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, CreateSyncedBookmarks) {
CreateSyncedBookmarks) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
......
...@@ -8419,6 +8419,17 @@ ...@@ -8419,6 +8419,17 @@
}, },
"test": "storage_unittests" "test": "storage_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"os": "Windows-10-15063"
}
]
},
"test": "sync_integration_tests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true, "can_use_on_swarming_builders": true,
......
...@@ -1040,7 +1040,6 @@ ...@@ -1040,7 +1040,6 @@
'remove_from': [ 'remove_from': [
# chromium.memory # chromium.memory
'Linux TSan Tests', # https://crbug.com/852002 'Linux TSan Tests', # https://crbug.com/852002
'win-asan', # https://crbug.com/875239
], ],
}, },
'performance_test_suite': { 'performance_test_suite': {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment