Introduce feature policy: document-stream-insertion

This CL introduces a new experimental feature
'document-stream-insertion' whose purpose is to limit the usage of
specific (anti-pattern) javascript API for "dynamic markup insertion".

The list of javascript methods to be blocked by this feature are:
document.{write, writeln, open, close}.
The set of disabled APIs is a subset of "dynamic-markup-insertion" from
HTML spec:

https://dev.w3.org/html5/spec-LC/apis-in-html-documents.html#dynamic-markup-insertion
https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dynamic-markup-insertion

Bug: 841605
Change-Id: I9cc31fab36e2cea70cdce575e3868ce1d0cfecfa
Reviewed-on: https://chromium-review.googlesource.com/1053349Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558847}

content/browser/frame_host/render_frame_host_feature_policy_unittest.cc

@@ -30,7 +30,7 @@ class RenderFrameHostFeaturePolicyTest
   static constexpr const char* kOrigin4 = "https://test.com";
 
   static const blink::mojom::FeaturePolicyFeature kDefaultEnabledFeature =
-      blink::mojom::FeaturePolicyFeature::kDocumentWrite;
+      blink::mojom::FeaturePolicyFeature::kDocumentStreamInsertion;
   static const blink::mojom::FeaturePolicyFeature kDefaultSelfFeature =
       blink::mojom::FeaturePolicyFeature::kGeolocation;
 

third_party/blink/common/feature_policy/feature_policy.cc

@@ -251,61 +251,62 @@ void FeaturePolicy::AddContainerPolicy(
 // See third_party/blink/public/common/feature_policy/feature_policy.h for
 // status of each feature (in spec, implemented, etc).
 const FeaturePolicy::FeatureList& FeaturePolicy::GetDefaultFeatureList() {
-  CR_DEFINE_STATIC_LOCAL(FeatureList, default_feature_list,
-                         ({{mojom::FeaturePolicyFeature::kAutoplay,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kCamera,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kEncryptedMedia,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kFullscreen,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kGeolocation,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kMicrophone,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kMidiFeature,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kPayment,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kSpeaker,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kDocumentCookie,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kDocumentDomain,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kDocumentWrite,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kSyncScript,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kSyncXHR,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kUsb,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kAccessibilityEvents,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kWebVr,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kAccelerometer,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kAmbientLightSensor,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kGyroscope,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kMagnetometer,
-                            FeaturePolicy::FeatureDefault::EnableForSelf},
-                           {mojom::FeaturePolicyFeature::kImageCompression,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kLegacyImageFormats,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kUnsizedMedia,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kAnimations,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kPictureInPicture,
-                            FeaturePolicy::FeatureDefault::EnableForAll},
-                           {mojom::FeaturePolicyFeature::kVerticalScroll,
-                            FeaturePolicy::FeatureDefault::EnableForAll}}));
+  CR_DEFINE_STATIC_LOCAL(
+      FeatureList, default_feature_list,
+      ({{mojom::FeaturePolicyFeature::kAutoplay,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kCamera,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kEncryptedMedia,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kFullscreen,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kGeolocation,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kMicrophone,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kMidiFeature,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kPayment,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kSpeaker,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kDocumentCookie,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kDocumentDomain,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kSyncScript,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kSyncXHR,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kUsb,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kAccessibilityEvents,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kWebVr,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kAccelerometer,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kAmbientLightSensor,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kGyroscope,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kMagnetometer,
+         FeaturePolicy::FeatureDefault::EnableForSelf},
+        {mojom::FeaturePolicyFeature::kImageCompression,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kLegacyImageFormats,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kUnsizedMedia,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kAnimations,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kPictureInPicture,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kVerticalScroll,
+         FeaturePolicy::FeatureDefault::EnableForAll},
+        {mojom::FeaturePolicyFeature::kDocumentStreamInsertion,
+         FeaturePolicy::FeatureDefault::EnableForAll}}));
   return default_feature_list;
 }
 

third_party/blink/public/mojom/feature_policy/feature_policy.mojom

@@ -58,8 +58,6 @@ enum FeaturePolicyFeature {
   kDocumentCookie,
   // Contols access to document.domain attribute.
   kDocumentDomain,
-  // Controls access to document.write and document.writeln methods.
-  kDocumentWrite,
   // Controls whether synchronous script elements will run.
   kSyncScript,
   // Controls use of synchronous XMLHTTPRequest API.
@@ -90,6 +88,10 @@ enum FeaturePolicyFeature {
   kPictureInPicture,
   // Controls the ability to block and interfere with vertical scrolling.
   kVerticalScroll,
+  // Controls the ability of the document to use several dynamic markup API
+  // which interfere with document's input stream (document.write(),
+  // document.close(), etc.).
+  kDocumentStreamInsertion,
 };
 
 // This struct holds feature policy whitelist data that needs to be replicated

third_party/blink/renderer/platform/feature_policy/feature_policy.cc

@@ -152,6 +152,7 @@ bool IsSupportedInFeaturePolicy(mojom::FeaturePolicyFeature feature) {
     case mojom::FeaturePolicyFeature::kVerticalScroll:
     case mojom::FeaturePolicyFeature::kLegacyImageFormats:
     case mojom::FeaturePolicyFeature::kImageCompression:
+    case mojom::FeaturePolicyFeature::kDocumentStreamInsertion:
       return RuntimeEnabledFeatures::ExperimentalProductivityFeaturesEnabled();
     default:
       return false;
@@ -193,6 +194,9 @@ const FeatureNameMap& GetDefaultFeatureNameMap() {
     default_feature_name_map.Set("picture-in-picture",
                                  mojom::FeaturePolicyFeature::kPictureInPicture);
     if (RuntimeEnabledFeatures::ExperimentalProductivityFeaturesEnabled()) {
+      default_feature_name_map.Set(
+          "document-stream-insertion",
+          mojom::FeaturePolicyFeature::kDocumentStreamInsertion);
       default_feature_name_map.Set(
           "image-compression", mojom::FeaturePolicyFeature::kImageCompression);
       default_feature_name_map.Set(
@@ -212,8 +216,6 @@ const FeatureNameMap& GetDefaultFeatureNameMap() {
           "cookie", mojom::FeaturePolicyFeature::kDocumentCookie);
       default_feature_name_map.Set(
           "domain", mojom::FeaturePolicyFeature::kDocumentDomain);
-      default_feature_name_map.Set("docwrite",
-                                   mojom::FeaturePolicyFeature::kDocumentWrite);
     }
     if (RuntimeEnabledFeatures::FeaturePolicyAutoplayFeatureEnabled()) {
       default_feature_name_map.Set("autoplay",