Commit 3f2e0bb7 authored by Mohamed Heikal's avatar Mohamed Heikal Committed by Commit Bot

Improve documentation on temporary android_deps BUILD.gn modifications

third_party/android_deps/BUILD.gn has some manual modifications due to
the migration of the android support library to androidx. This cl fixes
the warning output by the fetch_all.py script so it is more clear.

Bug: 896775
Change-Id: I490d50828cb19e2d1b47234aa1d9b777c097e428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072589
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Reviewed-by: default avatarSam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744653}
parent ec6f4fb1
......@@ -352,11 +352,17 @@ def main():
'--debug', action='store_true', help='Enable debug logging')
args = parser.parse_args()
print("""WARNING: Temporary manual edits have been made to
//third_party/android_deps/BUILD.gn to support the androidx migration.
This script will overwrite them, so you will need to revert them
afterwards.
E.g. by running: git checkout HEAD -p https://crbug.com/896775""")
msg = """
WARNING: Temporary manual edits have been made to
//third_party/android_deps/BUILD.gn to support the androidx migration.
This script will overwrite them, so you will need to revert them
afterwards. To do so you can run 'git checkout HEAD -p
third_party/android_deps/BUILD.gn' to interactively choose to revert
parts of the file that are not related to the specific package you are
adding or updating. See crrev.com/c/1830506 for the cl with the manual
changes for reference.
"""
print(msg)
# Determine Chromium source tree.
chromium_src = args.chromium_dir
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment