Commit 3f350b5e authored by Mike Dougherty's avatar Mike Dougherty Committed by Commit Bot

[iOS] Disable flaky Omnibox tests on iPad Simulator

Bug: 1128463
Change-Id: I32f05328e590ad7e8772cec8119e6d253d456853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412448
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: default avatarStepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807473}
parent 22af8892
......@@ -147,6 +147,13 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse(
// Tests that the switch to open tab button isn't displayed for the current tab.
- (void)testNotSwitchButtonOnCurrentTab {
// TODO(crbug.com/1128463): Test is flaky on iPad simulator.
#if TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_SKIPPED(@"This test is flaky on iPad simulators.");
}
#endif
// TODO(crbug.com/1067817): Test won't pass on iPad devices.
#if !TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) {
......@@ -270,12 +277,20 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse(
}
- (void)testDontCloseNTPWhenSwitchingWithForwardHistory {
// TODO(crbug.com/1128463): Test is flaky on iPad simulator.
#if TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_SKIPPED(@"This test is flaky on iPad simulators.");
}
#endif
// TODO(crbug.com/1067817): Test won't pass on iPad devices.
#if !TARGET_IPHONE_SIMULATOR
if ([ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_SKIPPED(@"This test doesn't pass on iPad device.");
}
#endif
// Open the first page.
GURL URL1 = self.testServer->GetURL(kPage1URL);
[ChromeEarlGrey loadURL:URL1];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment