Commit 3f3a5bf1 authored by Xiaohui Chen's avatar Xiaohui Chen Committed by Commit Bot

assisant: add aec flags

Bug: None
Test: flags unittests
Change-Id: I38ca60403e7ee50291a6685b1ab1c0e54e07d25f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829246Reviewed-by: default avatarTao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700916}
parent 85bca753
......@@ -4637,6 +4637,12 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_VALUE_TYPE(features::kLegacyTLSWarnings)},
#endif
#if defined(OS_CHROMEOS)
{"enable-assistant-aec", flag_descriptions::kEnableGoogleAssistantAecName,
flag_descriptions::kEnableGoogleAssistantAecDescription, kOsCrOS,
FEATURE_VALUE_TYPE(chromeos::assistant::features::kAssistantAudioEraser)},
#endif
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
......
......@@ -893,6 +893,11 @@
"owners": [ "beccahughes", "media-dev" ],
"expiry_milestone": 76
},
{
"name": "enable-assistant-aec",
"owners": [ "croissant-eng" ],
"expiry_milestone": 88
},
{
"name": "enable-assistant-app-support",
"owners": [ "croissant-eng" ],
......
......@@ -3384,6 +3384,11 @@ const char kEnableGoogleAssistantStereoInputDescription[] =
"Enable an experimental feature that uses stereo audio input for hotword "
"and voice to text detection in Google Assistant.";
const char kEnableGoogleAssistantAecName[] = "Enable Google Assistant AEC";
const char kEnableGoogleAssistantAecDescription[] =
"Enable an experimental feature that removes local feedback from audio "
"input to help hotword and ASR when background audio is playing.";
const char kEnableHeuristicStylusPalmRejectionName[] =
"Enable Heuristic for Stylus/Palm Rejection.";
const char kEnableHeuristicStylusPalmRejectionDescription[] =
......
......@@ -2010,6 +2010,9 @@ extern const char kEnableGoogleAssistantDspDescription[];
extern const char kEnableGoogleAssistantStereoInputName[];
extern const char kEnableGoogleAssistantStereoInputDescription[];
extern const char kEnableGoogleAssistantAecName[];
extern const char kEnableGoogleAssistantAecDescription[];
extern const char kEnableHeuristicStylusPalmRejectionName[];
extern const char kEnableHeuristicStylusPalmRejectionDescription[];
......
......@@ -36265,6 +36265,7 @@ from previous Chrome versions.
<int value="-240531943" label="ContextualSearchRankerQuery:disabled"/>
<int value="-239616243" label="HighDynamicRange:enabled"/>
<int value="-239176328" label="BluetoothAggressiveAppearanceFilter:enabled"/>
<int value="-237367320" label="AssistantAudioEraser:disabled"/>
<int value="-234966279" label="PointerEvent:disabled"/>
<int value="-234687894"
label="NonValidatingReloadOnRefreshContentV2:disabled"/>
......@@ -37293,6 +37294,7 @@ from previous Chrome versions.
<int value="1183431946" label="v8-cache-options"/>
<int value="1184225265" label="AllowSyncXHRInPageDismissal:enabled"/>
<int value="1185424279" label="enable-media-router"/>
<int value="1188109510" label="AssistantAudioEraser:enabled"/>
<int value="1190035852" label="MediaRemoting:enabled"/>
<int value="1192302892" label="gesture-typing"/>
<int value="1192913630" label="OfflinePagesBackgroundLoading:disabled"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment