Move some parts of HTMLSelectElement::DispatchBlurEvent() to SelectType

... as SelectType::DidBlur().

DispatchEventsIfSelectedOptionChanged() is now used only by
MenuListSelectType. This CL removes |SelectType::
DispatchEventsIfSelectedOptionChanged()|, and makes |MenuListSelectType
::DispatchEventsIfSelectedOptionChanged()| private.

This CL has no behavior changes.

Bug: 1052232
Change-Id: I791b4377719cc629d26d96f5c79a4ccd91ac9bbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081721Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746183}

third_party/blink/renderer/core/html/forms/html_select_element.cc

@@ -998,13 +998,7 @@ void HTMLSelectElement::DispatchBlurEvent(
     mojom::blink::FocusType type,
     InputDeviceCapabilities* source_capabilities) {
   type_ahead_.ResetSession();
-  // We only need to fire change events here for menu lists, because we fire
-  // change events for list boxes whenever the selection change is actually
-  // made.  This matches other browsers' behavior.
-  select_type_->DispatchEventsIfSelectedOptionChanged();
-  last_on_change_selection_.clear();
-  if (PopupIsVisible())
-    HidePopup();
+  select_type_->DidBlur();
   HTMLFormControlElementWithState::DispatchBlurEvent(new_focused_element, type,
                                                      source_capabilities);
 }

third_party/blink/renderer/core/html/forms/select_type.cc

@@ -68,7 +68,7 @@ class MenuListSelectType final : public SelectType {
   void DidSelectOption(HTMLOptionElement* element,
                        HTMLSelectElement::SelectOptionFlags flags,
                        bool should_update_popup) override;
-  void DispatchEventsIfSelectedOptionChanged() override;
+  void DidBlur() override;
 
   void UpdateTextStyle() override { UpdateTextStyleInternal(); }
   void UpdateTextStyleAndContent() override;
@@ -81,7 +81,7 @@ class MenuListSelectType final : public SelectType {
   bool ShouldOpenPopupForKeyPressEvent(const KeyboardEvent& event);
   // Returns true if this function handled the event.
   bool HandlePopupOpenKeyboardEvent();
-
+  void DispatchEventsIfSelectedOptionChanged();
   String UpdateTextStyleInternal();
   void DidUpdateActiveOption(HTMLOptionElement* option);
 
@@ -295,6 +295,16 @@ void MenuListSelectType::DispatchEventsIfSelectedOptionChanged() {
   }
 }
 
+void MenuListSelectType::DidBlur() {
+  // We only need to fire change events here for menu lists, because we fire
+  // change events for list boxes whenever the selection change is actually
+  // made.  This matches other browsers' behavior.
+  DispatchEventsIfSelectedOptionChanged();
+  if (select_->PopupIsVisible())
+    select_->HidePopup();
+  SelectType::DidBlur();
+}
+
 String MenuListSelectType::UpdateTextStyleInternal() {
   HTMLOptionElement* option = select_->OptionToBeShown();
   String text = g_empty_string;
@@ -723,7 +733,9 @@ void SelectType::DidSelectOption(HTMLOptionElement*,
   select_->SetNeedsValidityCheck();
 }
 
-void SelectType::DispatchEventsIfSelectedOptionChanged() {}
+void SelectType::DidBlur() {
+  select_->last_on_change_selection_.clear();
+}
 
 void SelectType::UpdateTextStyle() {}
 

third_party/blink/renderer/core/html/forms/select_type.h

@@ -28,7 +28,7 @@ class SelectType : public GarbageCollected<SelectType> {
                                HTMLSelectElement::SelectOptionFlags flags,
                                bool should_update_popup);
 
-  virtual void DispatchEventsIfSelectedOptionChanged();
+  virtual void DidBlur();
 
   // Update style of text in the CSS box on style or selected OPTION change.
   virtual void UpdateTextStyle();