Log InitializeICU() failures in relase build

Initialize failure causes immediate renderer crash. The logs about the
failures are useful for debugging the reason in the environemnt that
can reproduce the failure.

BUG=374362,376072
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/296293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272986 0039d316-1c4b-4281-b951-d872f2087c98
parent 76a13298
...@@ -69,13 +69,13 @@ bool InitializeICU() { ...@@ -69,13 +69,13 @@ bool InitializeICU() {
HMODULE module = LoadLibrary(data_path.value().c_str()); HMODULE module = LoadLibrary(data_path.value().c_str());
if (!module) { if (!module) {
DLOG(ERROR) << "Failed to load " << ICU_UTIL_DATA_SHARED_MODULE_NAME; LOG(ERROR) << "Failed to load " << ICU_UTIL_DATA_SHARED_MODULE_NAME;
return false; return false;
} }
FARPROC addr = GetProcAddress(module, ICU_UTIL_DATA_SYMBOL); FARPROC addr = GetProcAddress(module, ICU_UTIL_DATA_SYMBOL);
if (!addr) { if (!addr) {
DLOG(ERROR) << ICU_UTIL_DATA_SYMBOL << ": not found in " LOG(ERROR) << ICU_UTIL_DATA_SYMBOL << ": not found in "
<< ICU_UTIL_DATA_SHARED_MODULE_NAME; << ICU_UTIL_DATA_SHARED_MODULE_NAME;
return false; return false;
} }
...@@ -116,12 +116,12 @@ bool InitializeICU() { ...@@ -116,12 +116,12 @@ bool InitializeICU() {
FilePath data_path = FilePath data_path =
base::mac::PathForFrameworkBundleResource(CFSTR(ICU_UTIL_DATA_FILE_NAME)); base::mac::PathForFrameworkBundleResource(CFSTR(ICU_UTIL_DATA_FILE_NAME));
if (data_path.empty()) { if (data_path.empty()) {
DLOG(ERROR) << ICU_UTIL_DATA_FILE_NAME << " not found in bundle"; LOG(ERROR) << ICU_UTIL_DATA_FILE_NAME << " not found in bundle";
return false; return false;
} }
#endif // OS check #endif // OS check
if (!mapped_file.Initialize(data_path)) { if (!mapped_file.Initialize(data_path)) {
DLOG(ERROR) << "Couldn't mmap " << data_path.AsUTF8Unsafe(); LOG(ERROR) << "Couldn't mmap " << data_path.AsUTF8Unsafe();
return false; return false;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment