Commit 3f949687 authored by Yuta Kitamura's avatar Yuta Kitamura Committed by Commit Bot

Disable two UDPSocketTest tests on Fuchsia.

They are very flaky on Fuchsia.

Bug: 1014916
Change-Id: Id848846490fd3763fa4538c4ffb25463b6b17804
Tbr: parastoog@google.com
Tbr: mmenke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869051
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: default avatarYuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707305}
parent f20a51ea
...@@ -279,9 +279,18 @@ TEST_F(UDPSocketTest, TestSendToWithConnect) { ...@@ -279,9 +279,18 @@ TEST_F(UDPSocketTest, TestSendToWithConnect) {
EXPECT_EQ(net::ERR_UNEXPECTED, result); EXPECT_EQ(net::ERR_UNEXPECTED, result);
} }
// TODO(crbug.com/1014916): These two tests are very flaky on Fuchsia.
#if defined(OS_FUCHSIA)
#define MAYBE_TestReadSendTo DISABLED_TestReadSendTo
#define MAYBE_TestUnexpectedSequences DISABLED_TestUnexpectedSequences
#else
#define MAYBE_TestReadSendTo TestReadSendTo
#define MAYBE_TestUnexpectedSequences TestUnexpectedSequences
#endif
// Tests that the sequence of calling Bind()/Connect() and setters is // Tests that the sequence of calling Bind()/Connect() and setters is
// important. // important.
TEST_F(UDPSocketTest, TestUnexpectedSequences) { TEST_F(UDPSocketTest, MAYBE_TestUnexpectedSequences) {
mojo::Remote<mojom::UDPSocket> socket_remote; mojo::Remote<mojom::UDPSocket> socket_remote;
factory()->CreateUDPSocket(socket_remote.BindNewPipeAndPassReceiver(), factory()->CreateUDPSocket(socket_remote.BindNewPipeAndPassReceiver(),
mojo::NullRemote()); mojo::NullRemote());
...@@ -487,7 +496,7 @@ TEST_F(UDPSocketTest, TestReadSend) { ...@@ -487,7 +496,7 @@ TEST_F(UDPSocketTest, TestReadSend) {
EXPECT_EQ(msg, result.data.value()); EXPECT_EQ(msg, result.data.value());
} }
TEST_F(UDPSocketTest, TestReadSendTo) { TEST_F(UDPSocketTest, MAYBE_TestReadSendTo) {
// Create a server socket to send data. // Create a server socket to send data.
mojo::Remote<mojom::UDPSocket> server_socket; mojo::Remote<mojom::UDPSocket> server_socket;
factory()->CreateUDPSocket(server_socket.BindNewPipeAndPassReceiver(), factory()->CreateUDPSocket(server_socket.BindNewPipeAndPassReceiver(),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment