Commit 3fd4d13e authored by Peter Kasting's avatar Peter Kasting Committed by Commit Bot

Re-enable two disabled tests in c/b/ui/views/location_bar/.

This updates the comments on the other tests to have TODO form.

Bug: 163931, 823543, 824418
Change-Id: Ic82109fb4513a6b8053477ac28e5ee3969799f52
Reviewed-on: https://chromium-review.googlesource.com/c/1334842Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608959}
parent 934830c7
...@@ -25,7 +25,8 @@ class LocationIconViewTest : public InProcessBrowserTest { ...@@ -25,7 +25,8 @@ class LocationIconViewTest : public InProcessBrowserTest {
}; };
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
// Focusing or input is not completely working on Mac: http://crbug.com/824418 // TODO(robliao): https://crbug.com/824418 Focusing or input is not completely
// working on Mac.
#define MAYBE_HideOnSecondClick DISABLED_HideOnSecondClick #define MAYBE_HideOnSecondClick DISABLED_HideOnSecondClick
#else #else
#define MAYBE_HideOnSecondClick HideOnSecondClick #define MAYBE_HideOnSecondClick HideOnSecondClick
...@@ -65,7 +66,8 @@ IN_PROC_BROWSER_TEST_F(LocationIconViewTest, MAYBE_HideOnSecondClick) { ...@@ -65,7 +66,8 @@ IN_PROC_BROWSER_TEST_F(LocationIconViewTest, MAYBE_HideOnSecondClick) {
} }
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
// Widget activation doesn't work on Mac: https://crbug.com/823543 // TODO(robliao): https://crbug.com/823543 Widget activation doesn't work on
// Mac.
#define MAYBE_ActivateFirstInactiveBubbleForAccessibility \ #define MAYBE_ActivateFirstInactiveBubbleForAccessibility \
DISABLED_ActivateFirstInactiveBubbleForAccessibility DISABLED_ActivateFirstInactiveBubbleForAccessibility
#else #else
......
...@@ -44,10 +44,9 @@ class StarViewTest : public InProcessBrowserTest { ...@@ -44,10 +44,9 @@ class StarViewTest : public InProcessBrowserTest {
// Verify that clicking the bookmark star a second time hides the bookmark // Verify that clicking the bookmark star a second time hides the bookmark
// bubble. // bubble.
#if defined(OS_LINUX) && defined(USE_AURA) && !defined(OS_CHROMEOS) #if defined(OS_MACOSX)
#define MAYBE_HideOnSecondClick DISABLED_HideOnSecondClick // TODO(robliao): https://crbug.com/824418 Focusing or input is not completely
#elif defined(OS_MACOSX) // working on Mac.
// Focusing or input is not completely working on Mac: http://crbug.com/824418
#define MAYBE_HideOnSecondClick DISABLED_HideOnSecondClick #define MAYBE_HideOnSecondClick DISABLED_HideOnSecondClick
#else #else
#define MAYBE_HideOnSecondClick HideOnSecondClick #define MAYBE_HideOnSecondClick HideOnSecondClick
......
...@@ -39,15 +39,9 @@ void ShowInActiveTab(Browser* browser) { ...@@ -39,15 +39,9 @@ void ShowInActiveTab(Browser* browser) {
} // namespace } // namespace
// TODO(linux_aura) http://crbug.com/163931
#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA)
#define MAYBE_NonImmersiveFullscreen DISABLED_NonImmersiveFullscreen
#else
#define MAYBE_NonImmersiveFullscreen NonImmersiveFullscreen
#endif
// Test whether the zoom bubble is anchored and whether it is visible when in // Test whether the zoom bubble is anchored and whether it is visible when in
// non-immersive fullscreen. // non-immersive fullscreen.
IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, MAYBE_NonImmersiveFullscreen) { IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, NonImmersiveFullscreen) {
BrowserView* browser_view = static_cast<BrowserView*>(browser()->window()); BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
content::WebContents* web_contents = browser_view->GetActiveWebContents(); content::WebContents* web_contents = browser_view->GetActiveWebContents();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment