Run layout to avoid stale layout during SetIsInert()

Speculative fix for crbug.com/789094 Bug: 789094 Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc Reviewed-on: https://chromium-review.googlesource.com/c/823582Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#599171}

Run layout to avoid stale layout during SetIsInert()
Speculative fix for crbug.com/789094 Bug: 789094 Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc Reviewed-on: https://chromium-review.googlesource.com/c/823582Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#599171}
3fe6fcbb · Rune Lillesveen · Commit Bot · 7422130d · 3fe6fcbb · 3fe6fcbb
Commit 3fe6fcbb authored Oct 12, 2018 by Rune Lillesveen Committed by Commit Bot Oct 12, 2018
2 changed files
--- a/third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
+++ b/third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
+<!DOCTYPE html>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<iframe id="frame"></iframe>
+<script>
+  async_test(function(t) {
+    onload = t.step_func(() => {
+      const host = document.createElement("div");
+      frame.appendChild(host);
+      frame.contentDocument.body.innerHTML = "<dialog></dialog>";
+      document.body.offsetTop;
+      const root = host.createShadowRoot();
+      root.innerHTML = "<content>";
+      const dialog = frame.contentDocument.querySelector("dialog");
+      dialog.showModal();
+      t.done();
+    });
+  }, "Dialog.showModal() called when we have a dirty shadow distribution should not crash.");
+</script>
--- a/third_party/blink/renderer/core/html/html_dialog_element.cc
+++ b/third_party/blink/renderer/core/html/html_dialog_element.cc
@@ -175,12 +175,13 @@ void HTMLDialogElement::showModal(ExceptionState& exception_state) {
  GetDocument().AddToTopLayer(this);
  SetBooleanAttribute(openAttr, true);

+  ForceLayoutForCentering();
+
  // Throw away the AX cache first, so the subsequent steps don't have a chance
  // of queuing up AX events on objects that would be invalidated when the cache
  // is thrown away.
  InertSubtreesChanged(GetDocument(), *this);

-  ForceLayoutForCentering();
  SetFocusForDialog(this);
 }