Commit 4008d73c authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot

Add natvis support for |NGFragmentItem|

|NGFragmentItem| has a union. This change shows only the used
member of the union depending on its type.

|NGFragmentItems| has a flexible array. VS debugger could
show only the first item before this change. With this
change, synthetic |ArrayItems| shows all items.

Checked no warnings/errors with Natvis diagnostic messages
turned on in Tools/Options/Debugging/Output Window.

Bug: 982194
Change-Id: Ic5a75668c2e0482f7c6a00915459f6401886b9f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294837Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789848}
parent 017daef8
......@@ -274,6 +274,32 @@
</Synthetic>
</Expand>
</Type>
<Type Name="blink::NGFragmentItem">
<Expand>
<Item Name="Text" Condition="type_ == 0">text_</Item>
<Item Name="TextType" Condition="type_ == 0">(blink::NGTextType)sub_type_</Item>
<Item Name="GeneratedText" Condition="type_ == 1">generated_text_</Item>
<Item Name="Line" Condition="type_ == 2">line_</Item>
<Item Name="LineBoxType" Condition="type_ == 2">(NGPhysicalLineBoxFragment::NGLineBoxType)sub_type_</Item>
<Item Name="Box" Condition="type_ == 3">box_</Item>
<Item Name="layout_object_">layout_object_</Item>
<Item Name="rect_">rect_</Item>
</Expand>
</Type>
<Type Name="blink::NGFragmentItems">
<Expand>
<Item Name="text_content_">text_content_</Item>
<Synthetic Name="Items">
<DisplayString>{size_}</DisplayString>
<Expand>
<ArrayItems>
<Size>size_</Size>
<ValuePointer>items_</ValuePointer>
</ArrayItems>
</Expand>
</Synthetic>
</Expand>
</Type>
<!-- Layout: TextRun -->
<Type Name="blink::TextRun">
<DisplayString Condition="is_8bit_">{data_.characters8,[len_]s}</DisplayString>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment