Remove IsNative

This was originally needed so that we wouldn't cast a
BrowserAccessibility* into a platform-specific subclass
in a unit test that was explicitly constructing the
parent class.

We got rid of all such unit tests now, so there's no longer a
need for IsNative.

Bug: None
Change-Id: I934f08f22aa497c3894ee60c0c8f13fb046fc98e
Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141047Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757753}

content/browser/accessibility/browser_accessibility.cc

@@ -229,10 +229,6 @@ BrowserAccessibility* BrowserAccessibility::PlatformGetSelectionContainer()
   return container;
 }
 
-bool BrowserAccessibility::IsNative() const {
-  return false;
-}
-
 bool BrowserAccessibility::IsDescendantOf(
     const BrowserAccessibility* ancestor) const {
   if (!ancestor)

content/browser/accessibility/browser_accessibility.h

@@ -323,11 +323,6 @@ class CONTENT_EXPORT BrowserAccessibility : public ui::AXPlatformNodeDelegate {
   typedef base::StringPairs HtmlAttributes;
   const HtmlAttributes& GetHtmlAttributes() const;
 
-  // Returns true if this is a native platform-specific object, vs a
-  // cross-platform generic object. Don't call ToBrowserAccessibilityXXX if
-  // IsNative returns false.
-  virtual bool IsNative() const;
-
   // Accessing accessibility attributes:
   //
   // There are dozens of possible attributes for an accessibility node,

content/browser/accessibility/browser_accessibility_android.cc

@@ -87,10 +87,6 @@ BrowserAccessibilityAndroid::~BrowserAccessibilityAndroid() {
     g_unique_id_map.Get().erase(unique_id());
 }
 
-bool BrowserAccessibilityAndroid::IsNative() const {
-  return true;
-}
-
 void BrowserAccessibilityAndroid::OnLocationChanged() {
   auto* manager =
       static_cast<BrowserAccessibilityManagerAndroid*>(this->manager());

content/browser/accessibility/browser_accessibility_android.h

@@ -26,7 +26,6 @@ class CONTENT_EXPORT BrowserAccessibilityAndroid : public BrowserAccessibility {
 
   // Overrides from BrowserAccessibility.
   void OnDataChanged() override;
-  bool IsNative() const override;
   void OnLocationChanged() override;
   base::string16 GetValue() const override;
 

content/browser/accessibility/browser_accessibility_auralinux.cc

@@ -11,7 +11,6 @@ namespace content {
 
 BrowserAccessibilityAuraLinux* ToBrowserAccessibilityAuraLinux(
     BrowserAccessibility* obj) {
-  DCHECK(!obj || obj->IsNative());
   return static_cast<BrowserAccessibilityAuraLinux*>(obj);
 }
 
@@ -57,10 +56,6 @@ ui::AXPlatformNode* BrowserAccessibilityAuraLinux::GetAXPlatformNode() const {
   return GetNode();
 }
 
-bool BrowserAccessibilityAuraLinux::IsNative() const {
-  return true;
-}
-
 base::string16 BrowserAccessibilityAuraLinux::GetText() const {
   return GetHypertext();
 }

content/browser/accessibility/browser_accessibility_auralinux.h

@@ -31,7 +31,6 @@ class BrowserAccessibilityAuraLinux : public BrowserAccessibility {
   // BrowserAccessibility methods.
   void OnDataChanged() override;
   ui::AXPlatformNode* GetAXPlatformNode() const override;
-  bool IsNative() const override;
   base::string16 GetText() const override;
   base::string16 GetHypertext() const override;
 

content/browser/accessibility/browser_accessibility_com_win.cc

@@ -1677,7 +1677,7 @@ void BrowserAccessibilityComWin::FireNativeEvent(LONG win_event_type) const {
 
 BrowserAccessibilityComWin* ToBrowserAccessibilityComWin(
     BrowserAccessibility* obj) {
-  if (!obj || !obj->IsNative())
+  if (!obj)
     return nullptr;
   auto* result = static_cast<BrowserAccessibilityWin*>(obj)->GetCOM();
   return result;

content/browser/accessibility/browser_accessibility_mac.h

@@ -28,7 +28,6 @@ class BrowserAccessibilityMac : public BrowserAccessibility {
  public:
   // BrowserAccessibility overrides.
   ~BrowserAccessibilityMac() override;
-  bool IsNative() const override;
   void OnDataChanged() override;
   uint32_t PlatformChildCount() const override;
   BrowserAccessibility* PlatformGetChild(uint32_t child_index) const override;

content/browser/accessibility/browser_accessibility_mac.mm

@@ -31,10 +31,6 @@ BrowserAccessibilityMac::~BrowserAccessibilityMac() {
   [browser_accessibility_cocoa_ release];
 }
 
-bool BrowserAccessibilityMac::IsNative() const {
-  return true;
-}
-
 void BrowserAccessibilityMac::OnDataChanged() {
   BrowserAccessibility::OnDataChanged();
 
@@ -180,14 +176,12 @@ BrowserAccessibility* BrowserAccessibilityMac::PlatformGetPreviousSibling()
 const BrowserAccessibilityCocoa* ToBrowserAccessibilityCocoa(
     const BrowserAccessibility* obj) {
   DCHECK(obj);
-  DCHECK(obj->IsNative());
   return static_cast<const BrowserAccessibilityMac*>(obj)->native_view();
 }
 
 BrowserAccessibilityCocoa* ToBrowserAccessibilityCocoa(
     BrowserAccessibility* obj) {
   DCHECK(obj);
-  DCHECK(obj->IsNative());
   return static_cast<BrowserAccessibilityMac*>(obj)->native_view();
 }
 

content/browser/accessibility/browser_accessibility_manager.cc

@@ -1534,7 +1534,7 @@ void BrowserAccessibilityManager::CollectChangedNodesAndParentsForAtomicUpdate(
     DCHECK(changed_node);
 
     BrowserAccessibility* obj = GetFromAXNode(changed_node);
-    if (obj && obj->IsNative())
+    if (obj)
       nodes_needing_update->insert(obj->GetAXPlatformNode());
 
     // When a node is a text node or line break, update its parent, because
@@ -1545,7 +1545,7 @@ void BrowserAccessibilityManager::CollectChangedNodesAndParentsForAtomicUpdate(
 
     if (ui::IsTextOrLineBreak(changed_node->data().role)) {
       BrowserAccessibility* parent_obj = GetFromAXNode(parent);
-      if (parent_obj && parent_obj->IsNative())
+      if (parent_obj)
         nodes_needing_update->insert(parent_obj->GetAXPlatformNode());
     }
 
@@ -1559,7 +1559,7 @@ void BrowserAccessibilityManager::CollectChangedNodesAndParentsForAtomicUpdate(
     }
 
     BrowserAccessibility* editable_root_obj = GetFromAXNode(editable_root);
-    if (editable_root_obj && editable_root_obj->IsNative())
+    if (editable_root_obj)
       nodes_needing_update->insert(editable_root_obj->GetAXPlatformNode());
   }
 }

content/browser/accessibility/browser_accessibility_manager_auralinux.cc

@@ -69,9 +69,6 @@ void BrowserAccessibilityManagerAuraLinux::FireSelectedEvent(
 void BrowserAccessibilityManagerAuraLinux::FireLoadingEvent(
     BrowserAccessibility* node,
     bool is_loading) {
-  if (!node->IsNative())
-    return;
-
   gfx::NativeViewAccessible obj = node->GetNativeViewAccessible();
   if (!ATK_IS_OBJECT(obj))
     return;
@@ -84,18 +81,12 @@ void BrowserAccessibilityManagerAuraLinux::FireLoadingEvent(
 void BrowserAccessibilityManagerAuraLinux::FireExpandedEvent(
     BrowserAccessibility* node,
     bool is_expanded) {
-  if (!node->IsNative())
-    return;
-
   ToBrowserAccessibilityAuraLinux(node)->GetNode()->OnExpandedStateChanged(
       is_expanded);
 }
 
 void BrowserAccessibilityManagerAuraLinux::FireEvent(BrowserAccessibility* node,
                                                      ax::mojom::Event event) {
-  if (!node->IsNative())
-    return;
-
   ToBrowserAccessibilityAuraLinux(node)->GetNode()->NotifyAccessibilityEvent(
       event);
 }
@@ -205,7 +196,7 @@ void BrowserAccessibilityManagerAuraLinux::OnNodeDataWillChange(
   // children-changed:add is handled with the generated Event::IGNORED_CHANGED.
   if (!old_node_data.IsIgnored() && new_node_data.IsIgnored()) {
     BrowserAccessibility* obj = GetFromID(old_node_data.id);
-    if (obj && obj->IsNative() && obj->GetParent()) {
+    if (obj && obj->GetParent()) {
       DCHECK(!obj->IsIgnored());
       g_signal_emit_by_name(obj->GetParent(), "children-changed::remove",
                             obj->GetIndexInParent(),
@@ -222,7 +213,7 @@ void BrowserAccessibilityManagerAuraLinux::OnSubtreeWillBeDeleted(
     return;
 
   BrowserAccessibility* obj = GetFromAXNode(node);
-  if (obj && obj->IsNative())
+  if (obj)
     ToBrowserAccessibilityAuraLinux(obj)->GetNode()->OnSubtreeWillBeDeleted();
 }
 

content/browser/accessibility/browser_accessibility_manager_mac.mm

@@ -203,9 +203,6 @@ void BrowserAccessibilityManagerMac::FireGeneratedEvent(
     ui::AXEventGenerator::Event event_type,
     BrowserAccessibility* node) {
   BrowserAccessibilityManager::FireGeneratedEvent(event_type, node);
-  if (!node->IsNative())
-    return;
-
   auto native_node = ToBrowserAccessibilityCocoa(node);
   DCHECK(native_node);
 
@@ -469,9 +466,6 @@ void BrowserAccessibilityManagerMac::FireGeneratedEvent(
 void BrowserAccessibilityManagerMac::FireNativeMacNotification(
     NSString* mac_notification,
     BrowserAccessibility* node) {
-  if (!node->IsNative())
-    return;
-
   DCHECK(mac_notification);
   auto native_node = ToBrowserAccessibilityCocoa(node);
   DCHECK(native_node);
@@ -494,7 +488,7 @@ void BrowserAccessibilityManagerMac::OnAtomicUpdateFinished(
   std::set<const BrowserAccessibilityCocoa*> changed_editable_roots;
   for (const auto& change : changes) {
     const BrowserAccessibility* obj = GetFromAXNode(change.node);
-    if (obj && obj->IsNative() && obj->HasState(ax::mojom::State::kEditable)) {
+    if (obj && obj->HasState(ax::mojom::State::kEditable)) {
       const BrowserAccessibilityCocoa* editable_root =
           [ToBrowserAccessibilityCocoa(obj) editableAncestor];
       if (editable_root && [editable_root instanceActive])

content/browser/accessibility/browser_accessibility_win.cc

@@ -47,10 +47,6 @@ ui::AXPlatformNode* BrowserAccessibilityWin::GetAXPlatformNode() const {
   return GetCOM();
 }
 
-bool BrowserAccessibilityWin::IsNative() const {
-  return true;
-}
-
 void BrowserAccessibilityWin::OnLocationChanged() {
   GetCOM()->FireNativeEvent(EVENT_OBJECT_LOCATIONCHANGE);
 }
@@ -104,13 +100,11 @@ BrowserAccessibilityComWin* BrowserAccessibilityWin::GetCOM() const {
 }
 
 BrowserAccessibilityWin* ToBrowserAccessibilityWin(BrowserAccessibility* obj) {
-  DCHECK(!obj || obj->IsNative());
   return static_cast<BrowserAccessibilityWin*>(obj);
 }
 
 const BrowserAccessibilityWin* ToBrowserAccessibilityWin(
     const BrowserAccessibility* obj) {
-  DCHECK(!obj || obj->IsNative());
   return static_cast<const BrowserAccessibilityWin*>(obj);
 }
 

content/browser/accessibility/browser_accessibility_win.h

@@ -26,7 +26,6 @@ class CONTENT_EXPORT BrowserAccessibilityWin : public BrowserAccessibility {
   // BrowserAccessibility methods.
   //
   ui::AXPlatformNode* GetAXPlatformNode() const override;
-  bool IsNative() const override;
   void OnLocationChanged() override;
   base::string16 GetText() const override;
   base::string16 GetHypertext() const override;