Commit 400adf34 authored by Peter K. Lee's avatar Peter K. Lee Committed by Commit Bot

Updated crbug numbers in several TODOs for Identity Disc

Bug: 961120
Change-Id: Ic0315eb4a99c9ccc3dcc22207de5838c2fb5fe2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624945
Auto-Submit: Peter Lee <pkl@chromium.org>
Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662208}
parent d00e9a1d
......@@ -347,7 +347,7 @@ using base::UserMetricsAction;
self.identityDiscButton.imageEdgeInsets = UIEdgeInsetsMake(
ntp_home::kIdentityAvatarMargin, ntp_home::kIdentityAvatarMargin,
ntp_home::kIdentityAvatarMargin, ntp_home::kIdentityAvatarMargin);
// TODO(crbug.com/961120): Set action on button to launch into Settings.
// TODO(crbug.com/965958): Set action on button to launch into Settings.
[self.headerView setIdentityDiscView:self.identityDiscButton];
// Register to receive the avatar of the currently signed in user.
......
......@@ -474,7 +474,7 @@ const char kNTPHelpURL[] =
// one is available. If not, use the default avatar and initiate a fetch
// in the background. When background fetch completes, all observers will
// be notified to refresh the user's avatar.
// TODO(crbug.com/961120): Implement observers. This avatar fetch code
// TODO(crbug.com/965966): Implement observers. This avatar fetch code
// is from the IdentityRefreshLogic in settings_table_view_controller.mm.
// Code can probably be shared.
ios::ChromeIdentityService* identityService =
......@@ -488,7 +488,7 @@ const char kNTPHelpURL[] =
// User is not signed in, show default avatar.
image = [self defaultAvatar];
}
// TODO(crbug.com/961120): Use ResizedAvatarCache when it accepts the
// TODO(crbug.com/965962): Use ResizedAvatarCache when it accepts the
// specification of different image sizes.
CGFloat dimension = ntp_home::kIdentityAvatarDimension;
if (image.size.width != dimension || image.size.height != dimension) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment