Commit 401e3d26 authored by Luciano Pacheco's avatar Luciano Pacheco Committed by Commit Bot

Disable flaky tests from ImageWriterWriteFromUrlOperationTest

The following tests have been failing on TSan builder:
ImageWriterWriteFromUrlOperationTest.SelectTargetWithExtension
ImageWriterWriteFromUrlOperationTest.SelectTargetWithoutExtension

Tbr: rdevlin.cronin@chromium.org
Bug: 859317
Change-Id: Ic75ece0e4cb2121220f490a24850da866d721f9c
Reviewed-on: https://chromium-review.googlesource.com/1121996Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571818}
parent e46ff0c6
......@@ -127,7 +127,15 @@ class ImageWriterWriteFromUrlOperationTest : public ImageWriterUnitTestBase {
MockOperationManager manager_;
};
TEST_F(ImageWriterWriteFromUrlOperationTest, SelectTargetWithoutExtension) {
// Crashes on Tsan. http://crbug.com/859317
#if defined(THREAD_SANITIZER)
#define MAYBE_SelectTargetWithoutExtension DISABLED_SelectTargetWithoutExtension
#define MAYBE_SelectTargetWithExtension DISABLED_SelectTargetWithExtension
#else
#define MAYBE_SelectTargetWithoutExtension SelectTargetWithoutExtension
#define MAYBE_SelectTargetWithExtension SelectTargetWithExtension
#endif
TEST_F(ImageWriterWriteFromUrlOperationTest, MAYBE_SelectTargetWithoutExtension) {
scoped_refptr<WriteFromUrlOperationForTest> operation =
CreateOperation(GURL("http://localhost/foo/bar"), "");
......@@ -142,7 +150,7 @@ TEST_F(ImageWriterWriteFromUrlOperationTest, SelectTargetWithoutExtension) {
content::RunAllTasksUntilIdle();
}
TEST_F(ImageWriterWriteFromUrlOperationTest, SelectTargetWithExtension) {
TEST_F(ImageWriterWriteFromUrlOperationTest, MAYBE_SelectTargetWithExtension) {
scoped_refptr<WriteFromUrlOperationForTest> operation =
CreateOperation(GURL("http://localhost/foo/bar.zip"), "");
......@@ -155,6 +163,9 @@ TEST_F(ImageWriterWriteFromUrlOperationTest, SelectTargetWithExtension) {
operation->Cancel();
}
#undef MAYBE_SelectTargetWithoutExtension
#undef MAYBE_SelectTargetWithExtension
TEST_F(ImageWriterWriteFromUrlOperationTest, DownloadFile) {
// This test actually triggers the URL fetch code, which will drain the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment