[oobe] make sure that onBeforeShow is called for all oobe dialogs

Bug: 955194
Change-Id: Ibb4b828b439d04166e1a00cc423bc525811ed4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117734Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753646}

chrome/browser/resources/chromeos/login/checking_downloading_update.js

@@ -99,13 +99,6 @@ Polymer({
     },
   },
 
-  onBeforeShow() {
-    this.behaviors.forEach((behavior) => {
-      if (behavior.onBeforeShow)
-        behavior.onBeforeShow.call(this);
-    });
-  },
-
   computeProgressMessage_(
       hasEstimate, defaultProgressMessage, estimatedTimeLeftMsg_) {
     if (hasEstimate)

chrome/browser/resources/chromeos/login/discover/discover_ui.js

@@ -138,6 +138,7 @@ function initializeDiscoverAPI() {
       }
       if (module) {
         this.hideAll_();
+        module.onBeforeShow();
         module.hidden = false;
         module.show();
       } else {

chrome/browser/resources/chromeos/login/offline_gaia.html

@@ -46,8 +46,8 @@
     <link rel="stylesheet" href="oobe_dialog_host.css">
     <link rel="stylesheet" href="gaia_card_parameters.css">
     <oobe-dialog role="dialog" has-buttons selected$="[[activeSection]]"
-        animation-in-progress$="[[animationInProgress]]" no-header
-        no-footer-padding>
+        id="dialog" no-header no-footer-padding
+        animation-in-progress$="[[animationInProgress]]">
       <div slot="footer">
         <img id="icon" src="chrome://theme/IDR_LOGO_GOOGLE_COLOR_90" alt="">
       </div>

chrome/browser/resources/chromeos/login/offline_gaia.js

@@ -50,6 +50,14 @@
       this.switchToEmailCard(true /* animated */);
     },
 
+    onBeforeShow() {
+      this.behaviors.forEach((behavior) => {
+        if (behavior.onBeforeShow)
+          behavior.onBeforeShow.call(this);
+      });
+      this.$$('#dialog').onBeforeShow();
+    },
+
     onForgotPasswordClicked_() {
       this.disabled = true;
       this.fire('dialogShown');

chrome/browser/resources/chromeos/login/oobe_adb_sideloading_screen.js

@@ -49,6 +49,10 @@ Polymer({
   },
 
   onBeforeShow(data) {
+    this.behaviors.forEach((behavior) => {
+      if (behavior.onBeforeShow)
+        behavior.onBeforeShow.call(this);
+    });
     this.setScreenState(this.SCREEN_STATE_SETUP);
   },
 

chrome/browser/resources/chromeos/login/oobe_terms_of_service.js

@@ -65,14 +65,6 @@ Polymer({
     this.$.termsOfServiceDialog.show();
   },
 
-  /** Called when dialog is shown */
-  onBeforeShow() {
-    this.behaviors.forEach((behavior) => {
-      if (behavior.onBeforeShow)
-        behavior.onBeforeShow.call(this);
-    });
-  },
-
   /**
    * This is called when strings are updated.
    * @override

chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js

@@ -40,6 +40,14 @@ login.createScreen(
               });
         },
 
+        /**
+         * Returns default event target element.
+         * @type {Object}
+         */
+        get defaultControl() {
+          return this.adPasswordChanged_;
+        },
+
         /**
          * Cancels password changing and drops the user back to the login
          * screen.

chrome/browser/resources/chromeos/login/screen_error_message.js

@@ -256,6 +256,7 @@ login.createScreen('ErrorMessageScreen', 'error-message', function() {
      */
     onBeforeShow(data) {
       cr.ui.Oobe.clearErrors();
+      $('error-message-md').onBeforeShow();
       $('error-message-back-button').disabled = !this.closable;
     },
 

chrome/browser/resources/chromeos/login/screen_gaia_signin.js

@@ -714,6 +714,7 @@ Polymer({
 
     this.$['offline-ad-auth'].onBeforeShow();
     this.$['signin-frame-dialog'].onBeforeShow();
+    this.$['offline-gaia'].onBeforeShow();
     this.$.pinDialog.onBeforeShow();
   },
 

chrome/browser/resources/chromeos/login/screen_password_changed.js

@@ -27,6 +27,14 @@ login.createScreen('PasswordChangedScreen', 'password-changed', function() {
       });
     },
 
+    /**
+     * Returns default event target element.
+     * @type {Object}
+     */
+    get defaultControl() {
+      return this.gaiaPasswordChanged_;
+    },
+
     /**
      * Cancels password migration and drops the user back to the login screen.
      */

chrome/browser/resources/chromeos/login/screen_recommend_apps.js

@@ -23,6 +23,15 @@ login.createScreen('RecommendAppsScreen', 'recommend-apps', function() {
       return $('recommend-apps-screen');
     },
 
+    /**
+     * Event handler that is invoked just before the screen is shown.
+     * @param {Object} data Screen init payload.
+     */
+    onBeforeShow(data) {
+      $('recommend-apps-loading').onBeforeShow();
+      $('recommend-apps-screen').onBeforeShow();
+    },
+
     /*
      * Executed on language change.
      */

chrome/browser/resources/chromeos/login/screen_sync_consent.js

@@ -22,6 +22,15 @@ login.createScreen('SyncConsentScreen', 'sync-consent', function() {
       return OOBE_UI_STATE.ONBOARDING;
     },
 
+    /**
+     * Event handler that is invoked just before the screen is shown.
+     * @param {Object} data Screen init payload.
+     */
+    onBeforeShow(data) {
+      $('sync-loading').onBeforeShow();
+      $('sync-consent-impl').onBeforeShow();
+    },
+
     /**
      * Event handler that is invoked just before the screen is hidden.
      */

chrome/browser/resources/chromeos/login/screen_tpm_error.js

@@ -17,6 +17,14 @@ login.createScreen('TPMErrorMessageScreen', 'tpm-error-message', function() {
       });
     },
 
+    /**
+     * Returns default event target element.
+     * @type {Object}
+     */
+    get defaultControl() {
+      return $('tpm-error-dialog');
+    },
+
     /**
      * Show TPM screen.
      */

chrome/browser/resources/chromeos/login/screen_update_required.js

@@ -39,6 +39,14 @@ login.createScreen('UpdateRequiredScreen', 'update-required', function() {
       return OOBE_UI_STATE.BLOCKING;
     },
 
+    /**
+     * Returns default event target element.
+     * @type {Object}
+     */
+    get defaultControl() {
+      return $('update-required-card');
+    },
+
     /** @param {string} domain Enterprise domain name */
     /** @param {string} device Device name */
     setEnterpriseAndDeviceName(enterpriseDomain, device) {

chrome/browser/resources/chromeos/login/security_token_pin.html

@@ -11,7 +11,7 @@
     <link rel="stylesheet" href="security_token_pin.css">
 
     <oobe-dialog class="gaia-dialog" has-buttons role="dialog"
-        title-key="securityTokenPinDialogTitle"
+        title-key="securityTokenPinDialogTitle" id="dialog"
         aria-label$="[[i18nDynamic(locale, 'securityTokenPinDialogTitle')]]"
         aria-describedby="description">
       <hd-iron-icon slot="oobe-icon" icon1x="oobe-32:lock"