Commit 4091aa04 authored by Reid Kleckner's avatar Reid Kleckner Committed by Commit Bot

Disable some dynamic code sandboxing tests with ASan

Windows ASan hotpatches executables and allocates RWX code pages, which
means we can't intercept memmove/memset, which ASan needs.
Reimplementing ASan's interception mechanism to avoid hotpatching is an
extended long term project.

R=pennymac@chromium.org
BUG=805414

Change-Id: I4b05235e5c8abac1055a3ed56a26ca2ba4b7ad22
Reviewed-on: https://chromium-review.googlesource.com/1105513Reviewed-by: default avatarPenny MacNeil <pennymac@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568613}
parent 7e6ff974
......@@ -406,6 +406,11 @@ TEST(ProcessMitigationsTest, CheckWin81DynamicCodePolicySuccess) {
if (base::win::GetVersion() < base::win::VERSION_WIN8_1)
return;
// TODO(crbug.com/805414): Windows ASan hotpatching requires dynamic code.
#if defined(ADDRESS_SANITIZER)
return;
#endif
base::string16 test_command = L"CheckPolicy ";
test_command += std::to_wstring(TESTPOLICY_DYNAMICCODE);
......@@ -487,6 +492,11 @@ TEST(ProcessMitigationsTest, CheckWin10DynamicCodeOptOutPolicySuccess) {
if (base::win::GetVersion() < base::win::VERSION_WIN10_RS1)
return;
// TODO(crbug.com/805414): Windows ASan hotpatching requires dynamic code.
#if defined(ADDRESS_SANITIZER)
return;
#endif
base::string16 test_command = L"CheckPolicy ";
test_command += std::to_wstring(TESTPOLICY_DYNAMICCODEOPTOUT);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment