Commit 409d3337 authored by Sophie Chang's avatar Sophie Chang Committed by Commit Bot

Move all blacklist checks for commit-time previews to commit

This does the move by removing the blacklist checks for commit-time
previews from the navigation start portion and will be checked for
real at ShouldCommitPreview

Bug: 1018799
Change-Id: I04248c87176376586c7ff07b8ff7c5bcea68c265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885637Reviewed-by: default avatarDoug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710205}
parent a9dcd64a
...@@ -281,11 +281,9 @@ PreviewsEligibilityReason PreviewsDeciderImpl::DeterminePreviewEligibility( ...@@ -281,11 +281,9 @@ PreviewsEligibilityReason PreviewsDeciderImpl::DeterminePreviewEligibility(
return PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE; return PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE;
passed_reasons->push_back( passed_reasons->push_back(
PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE); PreviewsEligibilityReason::BLACKLIST_UNAVAILABLE);
}
// The blacklist will disallow certain hosts for periods of time based on // The blacklist will disallow certain hosts for periods of time based on
// user's opting out of the preview. // user's opting out of the preview.
if (previews_black_list_) {
PreviewsEligibilityReason status = PreviewsEligibilityReason status =
previews_black_list_->IsLoadedAndAllowed( previews_black_list_->IsLoadedAndAllowed(
url, type, url, type,
......
...@@ -2073,10 +2073,6 @@ TEST_F(PreviewsDeciderImplTest, ...@@ -2073,10 +2073,6 @@ TEST_F(PreviewsDeciderImplTest,
std::vector<PreviewsEligibilityReason> checked_decisions = { std::vector<PreviewsEligibilityReason> checked_decisions = {
PreviewsEligibilityReason::URL_HAS_BASIC_AUTH, PreviewsEligibilityReason::URL_HAS_BASIC_AUTH,
PreviewsEligibilityReason::EXCLUDED_BY_MEDIA_SUFFIX, PreviewsEligibilityReason::EXCLUDED_BY_MEDIA_SUFFIX,
PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT,
PreviewsEligibilityReason::USER_BLACKLISTED,
PreviewsEligibilityReason::HOST_BLACKLISTED,
PreviewsEligibilityReason::RELOAD_DISALLOWED, PreviewsEligibilityReason::RELOAD_DISALLOWED,
}; };
...@@ -2300,10 +2296,6 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeAllowHintPreviewWithoutECT) { ...@@ -2300,10 +2296,6 @@ TEST_F(PreviewsDeciderImplTest, LogDecisionMadeAllowHintPreviewWithoutECT) {
std::vector<PreviewsEligibilityReason> checked_decisions = { std::vector<PreviewsEligibilityReason> checked_decisions = {
PreviewsEligibilityReason::URL_HAS_BASIC_AUTH, PreviewsEligibilityReason::URL_HAS_BASIC_AUTH,
PreviewsEligibilityReason::EXCLUDED_BY_MEDIA_SUFFIX, PreviewsEligibilityReason::EXCLUDED_BY_MEDIA_SUFFIX,
PreviewsEligibilityReason::BLACKLIST_DATA_NOT_LOADED,
PreviewsEligibilityReason::USER_RECENTLY_OPTED_OUT,
PreviewsEligibilityReason::USER_BLACKLISTED,
PreviewsEligibilityReason::HOST_BLACKLISTED,
PreviewsEligibilityReason::RELOAD_DISALLOWED, PreviewsEligibilityReason::RELOAD_DISALLOWED,
}; };
PreviewsUserData user_data(kDefaultPageId); PreviewsUserData user_data(kDefaultPageId);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment