Commit 409ff448 authored by shend's avatar shend Committed by Commit bot

Update SameSizeAsComputedStyle to reflect new changes.

SameSizeAsComputedStyle is meant to be tracking the data layout of
ComputedStyle. Recently, we've moved three DataRefs from ComputedStyle
to ComputedStyleBase without updating the size assert. This was a
silent issue because we changed only the layout, not the size.

This patch updates SameSizeAsComputedStyle to reflect the current state
of ComputedStyle.

BUG=628043

Review-Url: https://codereview.chromium.org/2863423002
Cr-Commit-Position: refs/heads/master@{#471092}
parent b69e051f
...@@ -72,10 +72,11 @@ ASSERT_SIZE(BorderValue, SameSizeAsBorderValue); ...@@ -72,10 +72,11 @@ ASSERT_SIZE(BorderValue, SameSizeAsBorderValue);
// re-create the same structure for an accurate size comparison. // re-create the same structure for an accurate size comparison.
struct SameSizeAsComputedStyle : public RefCounted<SameSizeAsComputedStyle> { struct SameSizeAsComputedStyle : public RefCounted<SameSizeAsComputedStyle> {
struct ComputedStyleBase { struct ComputedStyleBase {
void* data_refs[3];
unsigned bitfields_[4]; unsigned bitfields_[4];
} base_; } base_;
void* data_refs[7]; void* data_refs[4];
void* own_ptrs[1]; void* own_ptrs[1];
void* data_ref_svg_style; void* data_ref_svg_style;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment