Commit 40de7d0a authored by Josh Karlin's avatar Josh Karlin Committed by Commit Bot

Revert "Enable AsyncStackAdTagging by default"

This reverts commit 7bb2910f.

Reason for revert: Perf bots showing possible perf regressions. Other suspicious candidates landed around the same time but reverting this one to see if it helps.

Original change's description:
> Enable AsyncStackAdTagging by default
> 
> To be cautious we landed this patch behind a feature to make sure it
> wasn't hurting performance. We're not seeing anything in 28 day data
> on canary/dev to suggest that it's problematic, so launching via
> waterfall.
> 
> Bug: 851531
> Change-Id: I77fc899170d8b5f76e7d50a4db3a4e33e88b40ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053411
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Josh Karlin <jkarlin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743597}

TBR=dcheng@chromium.org,jkarlin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 851531
Change-Id: I24c12ce6fb9258a8aad683a4b09901740a78f49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074317Reviewed-by: default avatarJosh Karlin <jkarlin@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744644}
parent 5b5dff37
...@@ -37,7 +37,7 @@ namespace features { ...@@ -37,7 +37,7 @@ namespace features {
// Controls whether the AdTracker will look across async stacks to determine if // Controls whether the AdTracker will look across async stacks to determine if
// the currently running stack is ad related. // the currently running stack is ad related.
const base::Feature kAsyncStackAdTagging{"AsyncStackAdTagging", const base::Feature kAsyncStackAdTagging{"AsyncStackAdTagging",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
// Controls whether the AdTracker analyzes the whole pseudo-stack or just the // Controls whether the AdTracker analyzes the whole pseudo-stack or just the
// top of the stack when detecting ads. // top of the stack when detecting ads.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment