Commit 40f08a3d authored by Christos Froussios's avatar Christos Froussios Committed by Commit Bot

Revert "DevTools: do not report raw headers and cookies for protected subresources."

This reverts commit 6745e12d.

Reason for revert: Test raw-headers-for-protected-document.js is flaky (mostly failing)

Original change's description:
> DevTools: do not report raw headers and cookies for protected subresources.
>
> In case subresource request's site needs to have its document protected, don't
> send raw headers and cookies into the frame's renderer.
>
> Bug: 793692
> Change-Id: I9f41adfe35717eec284130f89ac92ecc78089969
> Reviewed-on: https://chromium-review.googlesource.com/821410
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523364}

TBR=creis@chromium.org,pfeldman@chromium.org

Change-Id: I2f4abad2167c23cf6218fe1806eeadb212ccb430
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793692,794128
Reviewed-on: https://chromium-review.googlesource.com/822190
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: default avatarChristos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523400}
parent 9e3ea37a
...@@ -1278,17 +1278,6 @@ void ResourceDispatcherHostImpl::ContinuePendingBeginRequest( ...@@ -1278,17 +1278,6 @@ void ResourceDispatcherHostImpl::ContinuePendingBeginRequest(
report_raw_headers = false; report_raw_headers = false;
} }
// Do not report raw headers if the request's site needs to be isolated
// from the current process.
if (report_raw_headers) {
bool is_isolated =
SiteIsolationPolicy::UseDedicatedProcessesForAllSites() ||
policy->IsIsolatedOrigin(url::Origin::Create(request_data.url));
if (is_isolated &&
!policy->CanAccessDataForOrigin(child_id, request_data.url))
report_raw_headers = false;
}
if (request_data.resource_type == RESOURCE_TYPE_PREFETCH || if (request_data.resource_type == RESOURCE_TYPE_PREFETCH ||
request_data.resource_type == RESOURCE_TYPE_FAVICON) { request_data.resource_type == RESOURCE_TYPE_FAVICON) {
do_not_prompt_for_login = true; do_not_prompt_for_login = true;
......
Tests that raw response headers are not reported in case of site isolation.
<script src="http://127.0.0.1:8000/inspector-protocol/network/resources/cookie.pl">
Cookie: cookie
<script src="http://devtools.oopif.test:8000/inspector-protocol/network/resources/cookie.pl">
No cookie
Tests that raw response headers are not reported in case of site isolation.
<script src="http://127.0.0.1:8000/inspector-protocol/network/resources/cookie.pl">
Cookie: cookie
<script src="http://devtools.oopif.test:8000/inspector-protocol/network/resources/cookie.pl">
Cookie: cookie
(async function(testRunner) {
var {page, session, dp} = await testRunner.startURL(
'resources/cookie.pl',
`Tests that raw response headers are not reported in case of site isolation.`);
await dp.Network.enable();
let count = 0;
dp.Network.onResponseReceived(response => {
testRunner.log(`\n<script src="${response.params.response.url}">`);
if (response.params.response.requestHeaders)
testRunner.log(`Cookie: ${response.params.response.headers['Cookie']}`);
else
testRunner.log(`No cookie`);
if (++count === 2)
testRunner.completeTest();
});
await dp.Runtime.evaluate({expression: `
const script = document.createElement('script');
script.src = 'cookie.pl';
document.head.appendChild(script);
const script2 = document.createElement('script');
script2.src = 'http://devtools.oopif.test:8000/inspector-protocol/network/resources/cookie.pl';
document.head.appendChild(script2);`
});
})
#!/usr/bin/perl
print "Status: 200 OK\r\n";
print "Cookie: cookie\r\n\r\n";
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment