Commit 411895b8 authored by wtc@chromium.org's avatar wtc@chromium.org

Revert 284806 "Disable two recent Channel ID-related CLs to inve..."

The cause of the secure QUIC performance degradation has been
identified and fixed in r286400.

> Disable two recent Channel ID-related CLs to investigate a secure QUIC performance degradation.
>
> The change to quic_stream_factory.cc disables
> https://codereview.chromium.org/346323002/
>
> The change to quic_crypto_client_stream.cc disables
> https://codereview.chromium.org/355293003/
>
> R=rch@chromium.org
> BUG=396185
>
> Review URL: https://codereview.chromium.org/414523004

R=rch@chromium.org
BUG=396185

Review URL: https://codereview.chromium.org/444123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287860 0039d316-1c4b-4281-b951-d872f2087c98
parent d6171a2c
...@@ -245,9 +245,7 @@ void QuicCryptoClientStream::DoHandshakeLoop( ...@@ -245,9 +245,7 @@ void QuicCryptoClientStream::DoHandshakeLoop(
CloseConnectionWithDetails(error, error_details); CloseConnectionWithDetails(error, error_details);
return; return;
} }
// TODO(wtc): a temporary change to measure the performance penalty of channel_id_sent_ = (channel_id_key_.get() != NULL);
// pooling connections less often if channel ID is used.
// channel_id_sent_ = (channel_id_key_.get() != NULL);
if (cached->proof_verify_details()) { if (cached->proof_verify_details()) {
client_session()->OnProofVerifyDetailsAvailable( client_session()->OnProofVerifyDetailsAvailable(
*cached->proof_verify_details()); *cached->proof_verify_details());
......
...@@ -487,12 +487,8 @@ QuicStreamFactory::QuicStreamFactory( ...@@ -487,12 +487,8 @@ QuicStreamFactory::QuicStreamFactory(
crypto_config_.AddCanonicalSuffix(".googlevideo.com"); crypto_config_.AddCanonicalSuffix(".googlevideo.com");
crypto_config_.SetProofVerifier( crypto_config_.SetProofVerifier(
new ProofVerifierChromium(cert_verifier, transport_security_state)); new ProofVerifierChromium(cert_verifier, transport_security_state));
// TODO(wtc): a temporary change to investigate the performance degradation
// caused by Channel ID lookup.
#if 0
crypto_config_.SetChannelIDSource( crypto_config_.SetChannelIDSource(
new ChannelIDSourceChromium(channel_id_service)); new ChannelIDSourceChromium(channel_id_service));
#endif
base::CPU cpu; base::CPU cpu;
if (cpu.has_aesni() && cpu.has_avx()) if (cpu.has_aesni() && cpu.has_avx())
crypto_config_.PreferAesGcm(); crypto_config_.PreferAesGcm();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment