Commit 412210af authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

Disable protocol dropdowns for autoconf printers

- This change disables non ipp/ipps protocols for autoconf printers,
  since selecting one for an autoconf printer could put the user in
  a broken state.
- Since we will disable the make/model dropdown in the edit dialog for
  autoconf printers, we want to prevent users from selecting a protocol
  that would require users to select their own PPD make/model.

Bug: 947183
Test: End to end manual, browsertest
Change-Id: I0d46626113f98a128e05cc7b6d95678e6e9301cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747148
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688583}
parent 16b36e6b
...@@ -65,16 +65,20 @@ ...@@ -65,16 +65,20 @@
<option value="ipps"> <option value="ipps">
$i18n{printerProtocolIpps} $i18n{printerProtocolIpps}
</option> </option>
<option value="http"> <option value="http"
disabled="[[isAutoconfPrinter_(pendingPrinter_.*)]]">
$i18n{printerProtocolHttp} $i18n{printerProtocolHttp}
</option> </option>
<option value="https"> <option value="https"
disabled="[[isAutoconfPrinter_(pendingPrinter_.*)]]">
$i18n{printerProtocolHttps} $i18n{printerProtocolHttps}
</option> </option>
<option value="socket"> <option value="socket"
disabled="[[isAutoconfPrinter_(pendingPrinter_.*)]]">
$i18n{printerProtocolAppSocket} $i18n{printerProtocolAppSocket}
</option> </option>
<option value="lpd"> <option value="lpd"
disabled="[[isAutoconfPrinter_(pendingPrinter_.*)]]">
$i18n{printerProtocolLpd} $i18n{printerProtocolLpd}
</option> </option>
<option value="usb" disabled="[[networkProtocolActive_]]"> <option value="usb" disabled="[[networkProtocolActive_]]">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment