[layout] Make an OOF table-layout:fixed not report an infinite max-size

Previously tables ignored the given fixed-inline-size. However due to a fix for grid/flex: https://chromium.googlesource.com/chromium/src/+/a0b54e201c5ae7f2a5d2a769531adb9c47ff54ba they started respecting them. The uncovered a bug in the NG out-of-flow calculation, (given that these set a fixed-inline-size on children). An OOF table with "table-layout: fixed", and a %-width will force its max-content size to infinity, consuming all available space. This patch only performs this adjustment if the table *isn't* OOF. Bug: 1123475 Change-Id: I8784eb3ce4294132f6e6b7cb95ad71464c2380f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388266Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#803639}

[layout] Make an OOF table-layout:fixed not report an infinite max-size
Previously tables ignored the given fixed-inline-size. However due to a fix for grid/flex: https://chromium.googlesource.com/chromium/src/+/a0b54e201c5ae7f2a5d2a769531adb9c47ff54ba they started respecting them. The uncovered a bug in the NG out-of-flow calculation, (given that these set a fixed-inline-size on children). An OOF table with "table-layout: fixed", and a %-width will force its max-content size to infinity, consuming all available space. This patch only performs this adjustment if the table *isn't* OOF. Bug: 1123475 Change-Id: I8784eb3ce4294132f6e6b7cb95ad71464c2380f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388266Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#803639}
412c0d5b · Ian Kilpatrick · Commit Bot · cb882c81 · 412c0d5b · 412c0d5b
Commit 412c0d5b authored Sep 01, 2020 by Ian Kilpatrick Committed by Commit Bot Sep 01, 2020
2 changed files
--- a/third_party/blink/renderer/core/layout/table_layout_algorithm_fixed.cc
+++ b/third_party/blink/renderer/core/layout/table_layout_algorithm_fixed.cc
@@ -226,7 +226,8 @@ void TableLayoutAlgorithmFixed::ApplyPreferredLogicalWidthQuirks(
  // In this example, the two inner tables should be as large as the outer
  // table. We can achieve this effect by making the maxwidth of fixed tables
  // with percentage widths be infinite.
-  if (table_->StyleRef().LogicalWidth().IsPercentOrCalc() &&
+  if (!table_->IsOutOfFlowPositioned() &&
+      table_->StyleRef().LogicalWidth().IsPercentOrCalc() &&
      max_width < kTableMaxWidth)
    max_width = LayoutUnit(kTableMaxWidth);
 }

--- a/third_party/blink/web_tests/external/wpt/css/css-tables/absolute-tables-012.html
+++ b/third_party/blink/web_tests/external/wpt/css/css-tables/absolute-tables-012.html
+<!DOCTYPE html>
+<link rel="help" href="https://drafts.csswg.org/css-tables-3/#abspos">
+<link rel="help" href="https://crbug.com/1123475">
+<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
+<meta name="assert" content="When sizing abspos tables with `table-layout: fixed`, the max-content size shouldn't be infinite.">
+<p>Test passes if there is a filled green square.</p>
+<div style="position: relative; width: 200px;">
+  <table style="position: absolute; width: 50%; height: 100px; table-layout: fixed; background: green;"></table>
+</div>