Commit 412d3f12 authored by Eric Seckler's avatar Eric Seckler Committed by Commit Bot

Revert "Disabling flaky ChromeTracingDelegateBrowserTest tests."

This reverts commit 79081496.

Reason for revert: cause of the flakiness was identified and reverted

Original change's description:
> Disabling flaky ChromeTracingDelegateBrowserTest tests.
> 
> Tbr: skyostil@chromium.org
> Bug: 1012218
> Change-Id: If238d6632769c3f4faa4fde81d53b26ba83bdf01
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847293
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703677}

TBR=phoglund@chromium.org,skyostil@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012218
Change-Id: I69ed751afd7cf328232c2b303933dc9c66fa4fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852204Reviewed-by: default avatarEric Seckler <eseckler@chromium.org>
Reviewed-by: default avatarPatrik Höglund <phoglund@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704535}
parent d28a750b
......@@ -159,9 +159,16 @@ IN_PROC_BROWSER_TEST_F(ChromeTracingDelegateBrowserTest,
base::Closure(), content::BackgroundTracingManager::NO_DATA_FILTERING));
}
// Flaky. See https://crbug.com/723933 and https://crbug.com/1012218.
// Flaky on Linux and Windows. See https://crbug.com/723933.
#if defined(OS_LINUX) || defined(OS_WIN)
#define MAYBE_BackgroundTracingThrottleTimeElapsed \
DISABLED_BackgroundTracingThrottleTimeElapsed
#else
#define MAYBE_BackgroundTracingThrottleTimeElapsed \
BackgroundTracingThrottleTimeElapsed
#endif
IN_PROC_BROWSER_TEST_F(ChromeTracingDelegateBrowserTest,
DISABLED_BackgroundTracingThrottleTimeElapsed) {
MAYBE_BackgroundTracingThrottleTimeElapsed) {
base::RunLoop wait_for_upload;
EXPECT_TRUE(StartPreemptiveScenario(
......@@ -217,12 +224,18 @@ IN_PROC_BROWSER_TEST_F(ChromeTracingDelegateBrowserTest,
base::Closure(), content::BackgroundTracingManager::ANONYMIZE_DATA));
}
#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
// Flaky on ASAN on Mac. See https://crbug.com/674497.
// Flaky in general. See https://crbug.com/1012218.
#define MAYBE_NewIncognitoSessionBlockingTraceFinalization \
DISABLED_NewIncognitoSessionBlockingTraceFinalization
#else
#define MAYBE_NewIncognitoSessionBlockingTraceFinalization \
NewIncognitoSessionBlockingTraceFinalization
#endif
// If we need a PII-stripped trace, any new OTR session during tracing should
// block the finalization of the trace.
IN_PROC_BROWSER_TEST_F(ChromeTracingDelegateBrowserTest,
DISABLED_NewIncognitoSessionBlockingTraceFinalization) {
MAYBE_NewIncognitoSessionBlockingTraceFinalization) {
EXPECT_TRUE(StartPreemptiveScenario(
base::Closure(), content::BackgroundTracingManager::ANONYMIZE_DATA));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment